Mercurial > vim
diff src/channel.c @ 13598:8723e4496dd1 v8.0.1671
patch 8.0.1671: crash when passing non-dict argument as env to job_start()
commit https://github.com/vim/vim/commit/22efba47deb7e504142487fdc1617ec638cf0683
Author: Bram Moolenaar <Bram@vim.org>
Date: Sat Apr 7 13:22:21 2018 +0200
patch 8.0.1671: crash when passing non-dict argument as env to job_start()
Problem: Crash when passing non-dict argument as env to job_start().
Solution: Check for valid argument. (Ozaki Kiichi, closes https://github.com/vim/vim/issues/2765)
| author | Christian Brabandt <cb@256bit.org> |
|---|---|
| date | Sat, 07 Apr 2018 13:30:06 +0200 |
| parents | 97720d9a01d4 |
| children | 2a2b668cf24c |
line wrap: on
line diff
--- a/src/channel.c +++ b/src/channel.c @@ -4797,9 +4797,15 @@ get_job_options(typval_T *tv, jobopt_T * { if (!(supported2 & JO2_ENV)) break; + if (item->v_type != VAR_DICT) + { + EMSG2(_(e_invargval), "env"); + return FAIL; + } opt->jo_set2 |= JO2_ENV; opt->jo_env = item->vval.v_dict; - ++item->vval.v_dict->dv_refcount; + if (opt->jo_env != NULL) + ++opt->jo_env->dv_refcount; } else if (STRCMP(hi->hi_key, "cwd") == 0) {