Mercurial > vim
diff src/textprop.c @ 26775:2df40c348c70 v8.2.3916
patch 8.2.3916: no error for passing an invalid line number to append()
Commit: https://github.com/vim/vim/commit/8dac2acd6a79d571ff5409d9c90b4c9e73237eb4
Author: Bram Moolenaar <Bram@vim.org>
Date: Mon Dec 27 20:57:06 2021 +0000
patch 8.2.3916: no error for passing an invalid line number to append()
Problem: No error for passing an invalid line number to append().
Solution: In Vim9 script check for a non-negative number. (closes https://github.com/vim/vim/issues/9417)
| author | Bram Moolenaar <Bram@vim.org> |
|---|---|
| date | Mon, 27 Dec 2021 22:00:04 +0100 |
| parents | 685206b54ecf |
| children | bce848ec8b1b |
line wrap: on
line diff
--- a/src/textprop.c +++ b/src/textprop.c @@ -48,8 +48,6 @@ static hashtab_T *global_proptypes = NUL static int proptype_id = 0; static char_u e_type_not_exist[] = N_("E971: Property type %s does not exist"); -static char_u e_invalid_col[] = N_("E964: Invalid column number: %ld"); -static char_u e_invalid_lnum[] = N_("E966: Invalid line number: %ld"); /* * Find a property type by name, return the hashitem. @@ -169,7 +167,7 @@ f_prop_add(typval_T *argvars, typval_T * start_col = tv_get_number(&argvars[1]); if (start_col < 1) { - semsg(_(e_invalid_col), (long)start_col); + semsg(_(e_invalid_column_number_nr), (long)start_col); return; } if (argvars[2].v_type != VAR_DICT) @@ -213,12 +211,12 @@ prop_add_one( if (start_lnum < 1 || start_lnum > buf->b_ml.ml_line_count) { - semsg(_(e_invalid_lnum), (long)start_lnum); + semsg(_(e_invalid_line_number_nr), (long)start_lnum); return FAIL; } if (end_lnum < start_lnum || end_lnum > buf->b_ml.ml_line_count) { - semsg(_(e_invalid_lnum), (long)end_lnum); + semsg(_(e_invalid_line_number_nr), (long)end_lnum); return FAIL; } @@ -243,7 +241,7 @@ prop_add_one( col = 1; if (col - 1 > (colnr_T)textlen) { - semsg(_(e_invalid_col), (long)start_col); + semsg(_(e_invalid_column_number_nr), (long)start_col); return FAIL; }