Mercurial > vim
diff src/userfunc.c @ 31827:1009c33499e7 v9.0.1246
patch 9.0.1246: code is indented more than necessary
Commit: https://github.com/vim/vim/commit/142ed77898facf8f423fee2717efee1749c55f9a
Author: Yegappan Lakshmanan <yegappan@yahoo.com>
Date: Thu Jan 26 12:00:00 2023 +0000
patch 9.0.1246: code is indented more than necessary
Problem: Code is indented more than necessary.
Solution: Use an early return where it makes sense. (Yegappan Lakshmanan,
closes #11887)
author | Bram Moolenaar <Bram@vim.org> |
---|---|
date | Thu, 26 Jan 2023 13:15:04 +0100 |
parents | a98ef841fd01 |
children | 16025ef158bf |
line wrap: on
line diff
--- a/src/userfunc.c +++ b/src/userfunc.c @@ -770,25 +770,25 @@ is_function_cmd(char_u **cmd) static void function_using_block_scopes(ufunc_T *fp, cstack_T *cstack) { - if (cstack != NULL && cstack->cs_idx >= 0) - { - int count = cstack->cs_idx + 1; - int i; - - fp->uf_block_ids = ALLOC_MULT(int, count); - if (fp->uf_block_ids != NULL) - { - mch_memmove(fp->uf_block_ids, cstack->cs_block_id, - sizeof(int) * count); - fp->uf_block_depth = count; - } - - // Set flag in each block to indicate a function was defined. This - // is used to keep the variable when leaving the block, see - // hide_script_var(). - for (i = 0; i <= cstack->cs_idx; ++i) - cstack->cs_flags[i] |= CSF_FUNC_DEF; - } + if (cstack == NULL || cstack->cs_idx < 0) + return; + + int count = cstack->cs_idx + 1; + int i; + + fp->uf_block_ids = ALLOC_MULT(int, count); + if (fp->uf_block_ids != NULL) + { + mch_memmove(fp->uf_block_ids, cstack->cs_block_id, + sizeof(int) * count); + fp->uf_block_depth = count; + } + + // Set flag in each block to indicate a function was defined. This + // is used to keep the variable when leaving the block, see + // hide_script_var(). + for (i = 0; i <= cstack->cs_idx; ++i) + cstack->cs_flags[i] |= CSF_FUNC_DEF; } /* @@ -2433,21 +2433,20 @@ func_remove(ufunc_T *fp) return FALSE; hi = hash_find(&func_hashtab, UF2HIKEY(fp)); - if (!HASHITEM_EMPTY(hi)) - { - // When there is a def-function index do not actually remove the - // function, so we can find the index when defining the function again. - // Do remove it when it's a copy. - if (fp->uf_def_status == UF_COMPILED && (fp->uf_flags & FC_COPY) == 0) - { - fp->uf_flags |= FC_DEAD; - return FALSE; - } - hash_remove(&func_hashtab, hi, "remove function"); - fp->uf_flags |= FC_DELETED; - return TRUE; - } - return FALSE; + if (HASHITEM_EMPTY(hi)) + return FALSE; + + // When there is a def-function index do not actually remove the + // function, so we can find the index when defining the function again. + // Do remove it when it's a copy. + if (fp->uf_def_status == UF_COMPILED && (fp->uf_flags & FC_COPY) == 0) + { + fp->uf_flags |= FC_DEAD; + return FALSE; + } + hash_remove(&func_hashtab, hi, "remove function"); + fp->uf_flags |= FC_DELETED; + return TRUE; } static void