comparison src/gui.c @ 34194:a522c6c0127b v9.1.0047

patch 9.1.0047: issues with temp curwin/buf while cmdwin is open Commit: https://github.com/vim/vim/commit/988f74311c26ea9917e84fbae608de226dba7e5f Author: Sean Dewar <seandewar@users.noreply.github.com> Date: Wed Aug 16 14:17:36 2023 +0100 patch 9.1.0047: issues with temp curwin/buf while cmdwin is open Problem: Things that temporarily change/restore curwin/buf (e.g: win_execute, some autocmds) may break assumptions that curwin/buf is the cmdwin when "cmdwin_type != 0", causing issues. Solution: Expose the cmdwin's real win/buf and check that instead. Also try to ensure these variables are NULL if "cmdwin_type == 0", allowing them to be used directly in most cases without checking cmdwin_type. (Sean Dewar) Alternatively, we could ban win_execute in the cmdwin and audit all places that temporarily change/restore curwin/buf, but I didn't notice any problems arising from allowing this (standard cmdwin restrictions still apply, so things that may actually break the cmdwin are still forbidden). closes: #12819 Signed-off-by: Sean Dewar <seandewar@users.noreply.github.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
author Christian Brabandt <cb@256bit.org>
date Tue, 23 Jan 2024 23:00:04 +0100
parents 1629cc65d78d
children 995b539939c4
comparison
equal deleted inserted replaced
34193:00b0bd66410b 34194:a522c6c0127b
3978 3978
3979 // Don't put events in the input queue now. 3979 // Don't put events in the input queue now.
3980 if (hold_gui_events) 3980 if (hold_gui_events)
3981 return; 3981 return;
3982 3982
3983 if (cmdwin_type != 0 && sb->wp != curwin) 3983 if (cmdwin_type != 0 && sb->wp != cmdwin_win)
3984 return; 3984 return;
3985 3985
3986 if (still_dragging) 3986 if (still_dragging)
3987 { 3987 {
3988 if (sb->wp == NULL) 3988 if (sb->wp == NULL)