Mercurial > vim
comparison src/fileio.c @ 24578:096f2b8d9cf4 v8.2.2828
patch 8.2.2828: Coverity complains about not checking rename() return value
Commit: https://github.com/vim/vim/commit/97a6c6a1fb6043fd6520fbaaafc6970334186167
Author: Bram Moolenaar <Bram@vim.org>
Date: Mon May 3 19:49:51 2021 +0200
patch 8.2.2828: Coverity complains about not checking rename() return value
Problem: Coverity complains about not checking the rename() return value.
Solution: Add "(void)", can't do anything in case of a failure.
author | Bram Moolenaar <Bram@vim.org> |
---|---|
date | Mon, 03 May 2021 20:00:04 +0200 |
parents | 49d866e9b439 |
children | 7334bf933510 |
comparison
equal
deleted
inserted
replaced
24577:2cf982bc109e | 24578:096f2b8d9cf4 |
---|---|
3731 { | 3731 { |
3732 if (mch_rename(tempname, (char *)to) == 0) | 3732 if (mch_rename(tempname, (char *)to) == 0) |
3733 return 0; | 3733 return 0; |
3734 // Strange, the second step failed. Try moving the | 3734 // Strange, the second step failed. Try moving the |
3735 // file back and return failure. | 3735 // file back and return failure. |
3736 mch_rename(tempname, (char *)from); | 3736 (void)mch_rename(tempname, (char *)from); |
3737 return -1; | 3737 return -1; |
3738 } | 3738 } |
3739 // If it fails for one temp name it will most likely fail | 3739 // If it fails for one temp name it will most likely fail |
3740 // for any temp name, give up. | 3740 // for any temp name, give up. |
3741 return -1; | 3741 return -1; |