Mercurial > vim
annotate src/iid_ole.c @ 34627:5071d4c3ff2e v9.1.0202
patch 9.1.0202: leaking memory in add_user() on failure
Commit: https://github.com/vim/vim/commit/7a2f217988afa1c35b9c093a9d3477198ea250b9
Author: Christian Brabandt <cb@256bit.org>
Date: Sun Mar 24 09:50:03 2024 +0100
patch 9.1.0202: leaking memory in add_user() on failure
Problem: leaking memory in add_user() (LuMingYinDetect)
Solution: free user_copy pointer instead of the user ptr
add_user() is called with a user pointer and the user pointer comes
from these functions:
- return value from the getpwent() function (Unix).
- return value from the getpwnam() function (Unix).
- return value from the NetUserEnum() function (MS Windows).
For the first 2 callers, the man page for those functions directly says,
one should not free the returned pointer (since it comes from static
memory).
For the third caller (on MS Windows), the returned buffer is already
freed directly after calling the add_user() function in
NetApiBufferFree(), so this would lead to a double free().
This all indicates, the user ptr is wrongly freed in the add_user()
function and the intention was to free the user_copy pointer instead in
case of an error.
So let's just use that now.
fixes: #14250
closes: #14260
Signed-off-by: Christian Brabandt <cb@256bit.org>
author | Christian Brabandt <cb@256bit.org> |
---|---|
date | Sun, 24 Mar 2024 10:00:09 +0100 |
parents | 82c732e8d23d |
children |
rev | line source |
---|---|
18933
82c732e8d23d
patch 8.2.0027: still some /* */ comments
Bram Moolenaar <Bram@vim.org>
parents:
1351
diff
changeset
|
1 // this file contains the actual definitions of |
82c732e8d23d
patch 8.2.0027: still some /* */ comments
Bram Moolenaar <Bram@vim.org>
parents:
1351
diff
changeset
|
2 // the IIDs and CLSIDs |
7 | 3 |
18933
82c732e8d23d
patch 8.2.0027: still some /* */ comments
Bram Moolenaar <Bram@vim.org>
parents:
1351
diff
changeset
|
4 // link this file in with the server and any clients |
7 | 5 |
6 | |
18933
82c732e8d23d
patch 8.2.0027: still some /* */ comments
Bram Moolenaar <Bram@vim.org>
parents:
1351
diff
changeset
|
7 // File created by MIDL compiler version 3.00.44 |
82c732e8d23d
patch 8.2.0027: still some /* */ comments
Bram Moolenaar <Bram@vim.org>
parents:
1351
diff
changeset
|
8 // at Sat Jan 03 16:34:55 1998 |
82c732e8d23d
patch 8.2.0027: still some /* */ comments
Bram Moolenaar <Bram@vim.org>
parents:
1351
diff
changeset
|
9 // Compiler settings for if_ole.idl: |
82c732e8d23d
patch 8.2.0027: still some /* */ comments
Bram Moolenaar <Bram@vim.org>
parents:
1351
diff
changeset
|
10 // Os (OptLev=s), W1, Zp8, env=Win32, ms_ext, c_ext |
82c732e8d23d
patch 8.2.0027: still some /* */ comments
Bram Moolenaar <Bram@vim.org>
parents:
1351
diff
changeset
|
11 // error checks: none |
7 | 12 //@@MIDL_FILE_HEADING( ) |
13 #ifdef __cplusplus | |
14 extern "C"{ | |
15 #endif | |
16 | |
1351 | 17 #ifdef __MINGW32__ |
18 # include <w32api.h> | |
19 | |
20 # if __W32API_MAJOR_VERSION == 3 && __W32API_MINOR_VERSION < 10 | |
18933
82c732e8d23d
patch 8.2.0027: still some /* */ comments
Bram Moolenaar <Bram@vim.org>
parents:
1351
diff
changeset
|
21 // This define is missing from older MingW versions of w32api, even though |
82c732e8d23d
patch 8.2.0027: still some /* */ comments
Bram Moolenaar <Bram@vim.org>
parents:
1351
diff
changeset
|
22 // IID is defined. |
1351 | 23 # define __IID_DEFINED__ |
24 # endif | |
25 #endif | |
7 | 26 |
27 #ifndef __IID_DEFINED__ | |
1351 | 28 # define __IID_DEFINED__ |
7 | 29 |
30 typedef struct _IID | |
31 { | |
32 unsigned long x; | |
33 unsigned short s1; | |
34 unsigned short s2; | |
35 unsigned char c[8]; | |
36 } IID; | |
37 | |
1351 | 38 #endif |
7 | 39 |
40 #ifndef CLSID_DEFINED | |
1351 | 41 # define CLSID_DEFINED |
7 | 42 typedef IID CLSID; |
1351 | 43 #endif |
7 | 44 |
45 const IID IID_IVim = {0x0F0BFAE2,0x4C90,0x11d1,{0x82,0xD7,0x00,0x04,0xAC,0x36,0x85,0x19}}; | |
46 | |
47 | |
48 const IID LIBID_Vim = {0x0F0BFAE0,0x4C90,0x11d1,{0x82,0xD7,0x00,0x04,0xAC,0x36,0x85,0x19}}; | |
49 | |
50 | |
51 const CLSID CLSID_Vim = {0x0F0BFAE1,0x4C90,0x11d1,{0x82,0xD7,0x00,0x04,0xAC,0x36,0x85,0x19}}; | |
52 | |
53 | |
54 #ifdef __cplusplus | |
55 } | |
56 #endif | |
57 |