Mercurial > vim
annotate runtime/compiler/perlcritic.vim @ 34548:db67c09ccd53 v9.1.0175
patch 9.1.0175: wrong window positions with 'winfix{width,height}'
Commit: https://github.com/vim/vim/commit/5866bc3a0f54115d5982fdc09bdbe4c45069265a
Author: Sean Dewar <6256228+seandewar@users.noreply.github.com>
Date: Wed Mar 13 20:17:24 2024 +0100
patch 9.1.0175: wrong window positions with 'winfix{width,height}'
Problem: winframe functions incorrectly recompute window positions if
the altframe wasn't adjacent to the closed frame, which is
possible if adjacent windows had 'winfix{width,height}' set.
Solution: recompute for windows within the parent of the altframe and
closed frame. Skip this (as before) if the altframe was
top/left, but only if adjacent to the closed frame, as
positions won't change in that case. Also correct the return
value documentation for win_screenpos. (Sean Dewar)
The issue revealed itself after removing the win_comp_pos call below
winframe_restore in win_splitmove. Similarly, wrong positions could result from
windows closed in other tabpages, as win_free_mem uses winframe_remove (at least
until it is entered later, where enter_tabpage calls win_comp_pos).
NOTE: As win_comp_pos handles only curtab, it's possible via other means for
positions in non-current tabpages to be wrong (e.g: after changing 'laststatus',
'showtabline', etc.). Given enter_tabpage recomputes it, maybe it's intentional
as an optimization? Should probably be documented in win_screenpos then, but I
won't address that here.
closes: #14191
Signed-off-by: Sean Dewar <6256228+seandewar@users.noreply.github.com>
Signed-off-by: Christian Brabandt <cb@256bit.org>
author | Christian Brabandt <cb@256bit.org> |
---|---|
date | Wed, 13 Mar 2024 20:30:03 +0100 |
parents | d1fe80fb35e6 |
children | e1df51f68736 |
rev | line source |
---|---|
29150 | 1 " Vim compiler file |
2 " Compiler: perlcritic | |
3 " Maintainer: vim-perl <vim-perl@googlegroups.com> | |
4 " Author: Doug Kearns <dougkearns@gmail.com> | |
5 " Homepage: https://github.com/vim-perl/vim-perl | |
6 " Bugs/requests: https://github.com/vim-perl/vim-perl/issues | |
7 " License: Vim License (see :help license) | |
8 " Last Change: 2021 Oct 20 | |
9 | |
10 if exists("current_compiler") | |
11 finish | |
12 endif | |
13 let current_compiler = "perlcritic" | |
14 | |
15 if exists(":CompilerSet") != 2 " older Vim always used :setlocal | |
16 command -nargs=* CompilerSet setlocal <args> | |
17 endif | |
18 | |
19 let s:cpo_save = &cpo | |
20 set cpo&vim | |
21 | |
22 CompilerSet makeprg=perlcritic\ --nocolor\ --quiet\ --verbose\ \"\\%f:\\%l:\\%c:\\%s:\\%m\\n\" | |
23 CompilerSet errorformat=%f:%l:%c:%n:%m, | |
24 \%-G%.%# | |
25 | |
26 let &cpo = s:cpo_save | |
27 unlet s:cpo_save |