Mercurial > vim
annotate nsis/gvim_version.nsh @ 33262:6eac4f616293 v9.0.1899
patch 9.0.1899: potential buffer overflow in PBYTE macro
Commit: https://github.com/vim/vim/commit/ffb13674d1af1c90beb229867ec989e4fb232df3
Author: Christian Brabandt <cb@256bit.org>
Date: Fri Sep 15 20:22:02 2023 +0200
patch 9.0.1899: potential buffer overflow in PBYTE macro
Problem: potential buffer overflow in PBYTE macro
Solution: Check returned memline length
closes: #13083
the PBYTE macro is used to put byte c at a position lp of the returned
memline. However, in case of unexpected errors ml_get_buf() may return
either "???" or an empty line in which case it is quite likely that we
are causing a buffer overrun.
Therefore, switch the macro PBYTE (which is only used in ops.c anyhow)
to a function, that verifies that we will only try to access within the
given length of the buffer.
Also, since the macro is only used in ops.c, move the definition from
macros.h to ops.c
Signed-off-by: Christian Brabandt <cb@256bit.org>
author | Christian Brabandt <cb@256bit.org> |
---|---|
date | Fri, 15 Sep 2023 20:30:07 +0200 |
parents | f8116058ca76 |
children | 4635e43f2c6f |
rev | line source |
---|---|
7443
357b7bd8d612
commit https://github.com/vim/vim/commit/6c7b44472f7055c78d996e1b626bd2932502212f
Christian Brabandt <cb@256bit.org>
parents:
diff
changeset
|
1 # Generated from Makefile: define the version numbers |
357b7bd8d612
commit https://github.com/vim/vim/commit/6c7b44472f7055c78d996e1b626bd2932502212f
Christian Brabandt <cb@256bit.org>
parents:
diff
changeset
|
2 !ifndef __GVIM_VER__NSH__ |
357b7bd8d612
commit https://github.com/vim/vim/commit/6c7b44472f7055c78d996e1b626bd2932502212f
Christian Brabandt <cb@256bit.org>
parents:
diff
changeset
|
3 !define __GVIM_VER__NSH__ |
29314 | 4 !define VER_MAJOR 9 |
5 !define VER_MINOR 0 | |
7443
357b7bd8d612
commit https://github.com/vim/vim/commit/6c7b44472f7055c78d996e1b626bd2932502212f
Christian Brabandt <cb@256bit.org>
parents:
diff
changeset
|
6 !endif |