annotate runtime/compiler/shellcheck.vim @ 34194:a522c6c0127b v9.1.0047

patch 9.1.0047: issues with temp curwin/buf while cmdwin is open Commit: https://github.com/vim/vim/commit/988f74311c26ea9917e84fbae608de226dba7e5f Author: Sean Dewar <seandewar@users.noreply.github.com> Date: Wed Aug 16 14:17:36 2023 +0100 patch 9.1.0047: issues with temp curwin/buf while cmdwin is open Problem: Things that temporarily change/restore curwin/buf (e.g: win_execute, some autocmds) may break assumptions that curwin/buf is the cmdwin when "cmdwin_type != 0", causing issues. Solution: Expose the cmdwin's real win/buf and check that instead. Also try to ensure these variables are NULL if "cmdwin_type == 0", allowing them to be used directly in most cases without checking cmdwin_type. (Sean Dewar) Alternatively, we could ban win_execute in the cmdwin and audit all places that temporarily change/restore curwin/buf, but I didn't notice any problems arising from allowing this (standard cmdwin restrictions still apply, so things that may actually break the cmdwin are still forbidden). closes: #12819 Signed-off-by: Sean Dewar <seandewar@users.noreply.github.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
author Christian Brabandt <cb@256bit.org>
date Tue, 23 Jan 2024 23:00:04 +0100
parents a3bb84cd0f59
children e1df51f68736
Ignore whitespace changes - Everywhere: Within whitespace: At end of lines:
rev   line source
22441
a3bb84cd0f59 Update runtime files.
Bram Moolenaar <Bram@vim.org>
parents:
diff changeset
1 " Vim compiler file
a3bb84cd0f59 Update runtime files.
Bram Moolenaar <Bram@vim.org>
parents:
diff changeset
2 " Compiler: ShellCheck
a3bb84cd0f59 Update runtime files.
Bram Moolenaar <Bram@vim.org>
parents:
diff changeset
3 " Maintainer: Doug Kearns <dougkearns@gmail.com>
a3bb84cd0f59 Update runtime files.
Bram Moolenaar <Bram@vim.org>
parents:
diff changeset
4 " Last Change: 2020 Sep 4
a3bb84cd0f59 Update runtime files.
Bram Moolenaar <Bram@vim.org>
parents:
diff changeset
5
a3bb84cd0f59 Update runtime files.
Bram Moolenaar <Bram@vim.org>
parents:
diff changeset
6 if exists("current_compiler")
a3bb84cd0f59 Update runtime files.
Bram Moolenaar <Bram@vim.org>
parents:
diff changeset
7 finish
a3bb84cd0f59 Update runtime files.
Bram Moolenaar <Bram@vim.org>
parents:
diff changeset
8 endif
a3bb84cd0f59 Update runtime files.
Bram Moolenaar <Bram@vim.org>
parents:
diff changeset
9 let current_compiler = "shellcheck"
a3bb84cd0f59 Update runtime files.
Bram Moolenaar <Bram@vim.org>
parents:
diff changeset
10
a3bb84cd0f59 Update runtime files.
Bram Moolenaar <Bram@vim.org>
parents:
diff changeset
11 if exists(":CompilerSet") != 2 " older Vim always used :setlocal
a3bb84cd0f59 Update runtime files.
Bram Moolenaar <Bram@vim.org>
parents:
diff changeset
12 command -nargs=* CompilerSet setlocal <args>
a3bb84cd0f59 Update runtime files.
Bram Moolenaar <Bram@vim.org>
parents:
diff changeset
13 endif
a3bb84cd0f59 Update runtime files.
Bram Moolenaar <Bram@vim.org>
parents:
diff changeset
14
a3bb84cd0f59 Update runtime files.
Bram Moolenaar <Bram@vim.org>
parents:
diff changeset
15 let s:cpo_save = &cpo
a3bb84cd0f59 Update runtime files.
Bram Moolenaar <Bram@vim.org>
parents:
diff changeset
16 set cpo&vim
a3bb84cd0f59 Update runtime files.
Bram Moolenaar <Bram@vim.org>
parents:
diff changeset
17
a3bb84cd0f59 Update runtime files.
Bram Moolenaar <Bram@vim.org>
parents:
diff changeset
18 CompilerSet makeprg=shellcheck\ -f\ gcc
a3bb84cd0f59 Update runtime files.
Bram Moolenaar <Bram@vim.org>
parents:
diff changeset
19 CompilerSet errorformat=%f:%l:%c:\ %trror:\ %m\ [SC%n],
a3bb84cd0f59 Update runtime files.
Bram Moolenaar <Bram@vim.org>
parents:
diff changeset
20 \%f:%l:%c:\ %tarning:\ %m\ [SC%n],
a3bb84cd0f59 Update runtime files.
Bram Moolenaar <Bram@vim.org>
parents:
diff changeset
21 \%f:%l:%c:\ %tote:\ %m\ [SC%n],
a3bb84cd0f59 Update runtime files.
Bram Moolenaar <Bram@vim.org>
parents:
diff changeset
22 \%-G%.%#
a3bb84cd0f59 Update runtime files.
Bram Moolenaar <Bram@vim.org>
parents:
diff changeset
23
a3bb84cd0f59 Update runtime files.
Bram Moolenaar <Bram@vim.org>
parents:
diff changeset
24 let &cpo = s:cpo_save
a3bb84cd0f59 Update runtime files.
Bram Moolenaar <Bram@vim.org>
parents:
diff changeset
25 unlet s:cpo_save