Mercurial > vim
annotate runtime/compiler/gjs.vim @ 33865:8cdb69ea3711 v9.0.2143
patch 9.0.2143: [security]: buffer-overflow in ex_substitute
Commit: https://github.com/vim/vim/commit/abfa13ebe92d81aaf66669c428d767847b577453
Author: Christian Brabandt <cb@256bit.org>
Date: Thu Nov 30 11:32:18 2023 +0100
patch 9.0.2143: [security]: buffer-overflow in ex_substitute
Problem: [security]: buffer-overflow in ex_substitute
Solution: clear memory after allocating
When allocating the new_start pointer in ex_substitute() the memory
pointer points to some garbage that the following for loop in
ex_cmds.c:4743 confuses and causes it to accessing the new_start pointer
beyond it's size, leading to a buffer-overlow.
So fix this by using alloc_clear() instead of alloc(), which will
clear the memory by NUL and therefore cause the loop to terminate
correctly.
Reported by @henices, thanks!
closes: #13596
Signed-off-by: Christian Brabandt <cb@256bit.org>
author | Christian Brabandt <cb@256bit.org> |
---|---|
date | Sun, 10 Dec 2023 15:16:05 +0100 |
parents | 0db0640e16e0 |
children | e1df51f68736 |
rev | line source |
---|---|
21825 | 1 " Vim compiler file |
2 " Compiler: GJS (Gnome JavaScript Bindings) | |
3 " Maintainer: Doug Kearns <dougkearns@gmail.com> | |
4 " Last Change: 2019 Jul 10 | |
5 | |
6 if exists("current_compiler") | |
7 finish | |
8 endif | |
9 let current_compiler = "gjs" | |
10 | |
11 if exists(":CompilerSet") != 2 " older Vim always used :setlocal | |
12 command -nargs=* CompilerSet setlocal <args> | |
13 endif | |
14 | |
15 let s:cpo_save = &cpo | |
16 set cpo&vim | |
17 | |
18 CompilerSet makeprg=gjs | |
19 CompilerSet errorformat=%.%#JS\ %tRROR:\ %m\ @\ %f:%c, | |
20 \%E%.%#JS\ ERROR:\ %m, | |
21 \%Z@%f:%l:%c, | |
22 \%-G%.%# | |
23 | |
24 let &cpo = s:cpo_save | |
25 unlet s:cpo_save |