annotate SECURITY.md @ 36119:74326a0d08f2 v9.1.0724

patch 9.1.0724: if_python: link error with python 3.13 and stable ABI Commit: https://github.com/vim/vim/commit/c2285a8cf397d1d694a350415fb37f7d51202ec4 Author: Yee Cheng Chin <ychin.git@gmail.com> Date: Mon Sep 9 19:55:24 2024 +0200 patch 9.1.0724: if_python: link error with python 3.13 and stable ABI Problem: if_python: link error with python 3.13 and stable ABI (zdohnal) Solution: Use the correct stable APIs Py_IncRef and Py_DecRef instead (Yee Cheng Chin) This fixes #15460 properly. There was an attempt to fix it in v9.1.0668, but it did it by manually copy and pasting definitions from Python 3.13 headers, which is problematic as it makes Vim dependent on low-level implementation details which are subject to change. That change also pulls in dependencies to private APIs (`_Py_IncRef`) which is a very bad idea as the next version of Python could very well remove that. The core issue was simply that `Py_INCREF` and similar functions are not part of the stable API. We are supposed to be using `Py_IncRef` instead which performs null-check (similar to `Py_XINCREF`) and is available as a linkable function. We simply need to call it instead of the macro. We simply remap `Py_INCREF` (and friends) to the function version in stable API similar to how we mapped other functions. related #15460 closes: #15648 Signed-off-by: Yee Cheng Chin <ychin.git@gmail.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
author Christian Brabandt <cb@256bit.org>
date Mon, 09 Sep 2024 20:00:12 +0200
parents 13e4398925ea
children
Ignore whitespace changes - Everywhere: Within whitespace: At end of lines:
rev   line source
32717
b807b0aa8e1f Add security policy (#12687)
Christian Brabandt <cb@256bit.org>
parents:
diff changeset
1 # Security Policy
b807b0aa8e1f Add security policy (#12687)
Christian Brabandt <cb@256bit.org>
parents:
diff changeset
2
b807b0aa8e1f Add security policy (#12687)
Christian Brabandt <cb@256bit.org>
parents:
diff changeset
3 ## Reporting a vulnerability
b807b0aa8e1f Add security policy (#12687)
Christian Brabandt <cb@256bit.org>
parents:
diff changeset
4
33648
13e4398925ea please report security issues to the vim-security list
Christian Brabandt <cb@256bit.org>
parents: 33616
diff changeset
5 If you want to report a security issue, please privately disclose the issue to the vim-security mailing list
13e4398925ea please report security issues to the vim-security list
Christian Brabandt <cb@256bit.org>
parents: 33616
diff changeset
6 vim-security@googlegroups.com
13e4398925ea please report security issues to the vim-security list
Christian Brabandt <cb@256bit.org>
parents: 33616
diff changeset
7
13e4398925ea please report security issues to the vim-security list
Christian Brabandt <cb@256bit.org>
parents: 33616
diff changeset
8 This is a private list, read only by the maintainers, but anybody can post, after moderation.
32717
b807b0aa8e1f Add security policy (#12687)
Christian Brabandt <cb@256bit.org>
parents:
diff changeset
9
b807b0aa8e1f Add security policy (#12687)
Christian Brabandt <cb@256bit.org>
parents:
diff changeset
10 **Please don't publicly disclose the issue until it has been addressed by us.**