Mercurial > vim
annotate src/testdir/dumps/Test_popupwin_menu_scroll_3a.dump @ 34379:37b4c89ba420 v9.1.0116
patch 9.1.0116: win_split_ins may not check available room
Commit: https://github.com/vim/vim/commit/0fd44a5ad81ade342cb54d8984965bdedd2272c8
Author: Sean Dewar <6256228+seandewar@users.noreply.github.com>
Date: Tue Feb 20 20:28:15 2024 +0100
patch 9.1.0116: win_split_ins may not check available room
Problem: win_split_ins has no check for E36 when moving an existing
window
Solution: check for room and fix the issues in f_win_splitmove()
(Sean Dewar)
win_split_ins has no check for E36 when moving an existing window,
allowing for layouts with many overlapping zero-sized windows to be
created (which may also cause drawing issues with tablines and such).
f_win_splitmove also has some bugs.
So check for room and fix the issues in f_win_splitmove. Handle failure
in the two relevant win_split_ins callers by restoring the original
layout, and factor the common logic into win_splitmove.
Don't check for room when opening an autocommand window, as it's a
temporary window that's rarely interacted with or drawn anyhow, and is
rather important for some autocommands.
Issues fixed in f_win_splitmove:
- Error if splitting is disallowed.
- Fix heap-use-after-frees if autocommands fired from switching to "targetwin"
close "wp" or "oldwin".
- Fix splitting the wrong window if autocommands fired from switching to
"targetwin" switch to a different window.
- Ensure -1 is returned for all errors.
Also handle allocation failure a bit earlier in make_snapshot (callers,
except win_splitmove, don't really care if a snapshot can't be made, so
just ignore the return value).
Note: Test_smoothscroll_in_zero_width_window failed after these changes with
E36, as it was using the previous behaviour to create a zero-width window.
I've fixed the test such that it fails with UBSAN as expected when v9.0.1367 is
reverted (and simplified it too).
related: #14042
Signed-off-by: Sean Dewar <6256228+seandewar@users.noreply.github.com>
Signed-off-by: Christian Brabandt <cb@256bit.org>
author | Christian Brabandt <cb@256bit.org> |
---|---|
date | Tue, 20 Feb 2024 22:30:04 +0100 |
parents | abf161ce0c77 |
children |
rev | line source |
---|---|
32782
abf161ce0c77
patch 9.0.1707: Cannot wrap around in popup_filter_menu()
Christian Brabandt <cb@256bit.org>
parents:
diff
changeset
|
1 >1+0&#ffffff0| @73 |
abf161ce0c77
patch 9.0.1707: Cannot wrap around in popup_filter_menu()
Christian Brabandt <cb@256bit.org>
parents:
diff
changeset
|
2 |2| @73 |
abf161ce0c77
patch 9.0.1707: Cannot wrap around in popup_filter_menu()
Christian Brabandt <cb@256bit.org>
parents:
diff
changeset
|
3 |3| @29|╔+0#0000001#ffd7ff255|═@10|╗| +0#0000000#ffffff0@30 |
abf161ce0c77
patch 9.0.1707: Cannot wrap around in popup_filter_menu()
Christian Brabandt <cb@256bit.org>
parents:
diff
changeset
|
4 |4| @29|║+0#0000001#ffd7ff255| |s|e|v|e|n| @3| +0#0000000#a8a8a8255|║+0#0000001#ffd7ff255| +0#0000000#ffffff0@30 |
abf161ce0c77
patch 9.0.1707: Cannot wrap around in popup_filter_menu()
Christian Brabandt <cb@256bit.org>
parents:
diff
changeset
|
5 |5| @29|║+0#0000001#ffd7ff255| |e|i|g|h|t| @3| +0#0000000#a8a8a8255|║+0#0000001#ffd7ff255| +0#0000000#ffffff0@30 |
abf161ce0c77
patch 9.0.1707: Cannot wrap around in popup_filter_menu()
Christian Brabandt <cb@256bit.org>
parents:
diff
changeset
|
6 |6| @29|║+0#0000001#ffd7ff255| |n+0&#e0e0e08|i|n|e| @3| +0&#ffd7ff255| +0#0000000#0000001|║+0#0000001#ffd7ff255| +0#0000000#ffffff0@30 |
abf161ce0c77
patch 9.0.1707: Cannot wrap around in popup_filter_menu()
Christian Brabandt <cb@256bit.org>
parents:
diff
changeset
|
7 |7| @29|╚+0#0000001#ffd7ff255|═@10|╝| +0#0000000#ffffff0@30 |
abf161ce0c77
patch 9.0.1707: Cannot wrap around in popup_filter_menu()
Christian Brabandt <cb@256bit.org>
parents:
diff
changeset
|
8 |8| @73 |
abf161ce0c77
patch 9.0.1707: Cannot wrap around in popup_filter_menu()
Christian Brabandt <cb@256bit.org>
parents:
diff
changeset
|
9 |9| @73 |
abf161ce0c77
patch 9.0.1707: Cannot wrap around in popup_filter_menu()
Christian Brabandt <cb@256bit.org>
parents:
diff
changeset
|
10 @57|1|,|1| @10|T|o|p| |