Mercurial > vim
annotate .codecov.yml @ 34094:0b25a862bf0c v9.1.0014
patch 9.1.0014: incorrect use of W_WINROW in edit.c
Commit: https://github.com/vim/vim/commit/b1ed7ec9f7d1a0142d4f1c8c83bab9172bc92c7c
Author: zeertzjq <zeertzjq@outlook.com>
Date: Fri Jan 5 18:11:43 2024 +0100
patch 9.1.0014: incorrect use of W_WINROW in edit.c
Problem: incorrect use of W_WINROW in edit.c
Solution: compare against curwin->w_height instead
Remove incorrect use of W_WINROW
In structs.h it is mentioned that w_wrow is relative to w_winrow, so
using W_WINROW doesn't make sense when comparing with window height.
This change won't lead to any observable behavior change:
The condition intends to check if there are 'scrolloff' lines between
the current cursor when the bottom of the window. When W_WINROW(curwin)
is added to curwin->w_height - 1 - get_scrolloff_value(), the condition
is instead satisfied when the cursor is on some screen line below that
position. However,
- If 'scrolloff' is smaller than half the window height, this condition
can only be satisfied when W_WINROW(curwin) == 0. And if it is not
satisfied, update_topline() does the actual scrolling.
- If 'scrolloff' is larger than half the window height, update_topline()
will put the cursor at the center of the window soon afterwards
anyway, because set_topline() now unsets VALID_TOPLINE flag starting
from https://github.com/vim/vim-history/commit/7db7bb45b0f919ff0615d463ebd4fde881c69d1f.
To put it in another way, https://github.com/vim/vim-history/commit/7db7bb45b0f919ff0615d463ebd4fde881c69d1f
makes the update_topline() just below correct the mistakes made in this
block, so this incorrect use of W_WINROW() no longer affects observable
behavior.
closes: #12331
Signed-off-by: zeertzjq <zeertzjq@outlook.com>
Signed-off-by: Christian Brabandt <cb@256bit.org>
author | Christian Brabandt <cb@256bit.org> |
---|---|
date | Fri, 05 Jan 2024 18:30:03 +0100 |
parents | 0b8312c5dfe0 |
children |
rev | line source |
---|---|
23608
3b378f03f713
patch 8.2.2346: Codecov reports every little coverage drop
Bram Moolenaar <Bram@vim.org>
parents:
diff
changeset
|
1 coverage: |
3b378f03f713
patch 8.2.2346: Codecov reports every little coverage drop
Bram Moolenaar <Bram@vim.org>
parents:
diff
changeset
|
2 range: "80...100" |
3b378f03f713
patch 8.2.2346: Codecov reports every little coverage drop
Bram Moolenaar <Bram@vim.org>
parents:
diff
changeset
|
3 status: |
3b378f03f713
patch 8.2.2346: Codecov reports every little coverage drop
Bram Moolenaar <Bram@vim.org>
parents:
diff
changeset
|
4 project: |
3b378f03f713
patch 8.2.2346: Codecov reports every little coverage drop
Bram Moolenaar <Bram@vim.org>
parents:
diff
changeset
|
5 default: |
3b378f03f713
patch 8.2.2346: Codecov reports every little coverage drop
Bram Moolenaar <Bram@vim.org>
parents:
diff
changeset
|
6 threshold: 0.05% |
28759
8bb342f944d3
patch 8.2.4904: codecov includes MS-Windows install files
Bram Moolenaar <Bram@vim.org>
parents:
23608
diff
changeset
|
7 |
33463
0b8312c5dfe0
patch 9.0.1985: CI: codecov is intrusive
Christian Brabandt <cb@256bit.org>
parents:
28761
diff
changeset
|
8 comment: false |
0b8312c5dfe0
patch 9.0.1985: CI: codecov is intrusive
Christian Brabandt <cb@256bit.org>
parents:
28761
diff
changeset
|
9 |
28759
8bb342f944d3
patch 8.2.4904: codecov includes MS-Windows install files
Bram Moolenaar <Bram@vim.org>
parents:
23608
diff
changeset
|
10 # Files not run by tests |
8bb342f944d3
patch 8.2.4904: codecov includes MS-Windows install files
Bram Moolenaar <Bram@vim.org>
parents:
23608
diff
changeset
|
11 ignore: |
8bb342f944d3
patch 8.2.4904: codecov includes MS-Windows install files
Bram Moolenaar <Bram@vim.org>
parents:
23608
diff
changeset
|
12 - "src/dosinst.c" |
28761
035fbd9bd1c6
patch 8.2.4905: codecov includes MS-Windows install header file
Bram Moolenaar <Bram@vim.org>
parents:
28759
diff
changeset
|
13 - "src/dosinst.h" |
28759
8bb342f944d3
patch 8.2.4904: codecov includes MS-Windows install files
Bram Moolenaar <Bram@vim.org>
parents:
23608
diff
changeset
|
14 - "src/uninstall.c" |