annotate runtime/indent/zsh.vim @ 33815:08f9e1eac4cf v9.0.2123

patch 9.0.2123: Problem with initializing the length of range() lists Commit: https://github.com/vim/vim/commit/df63da98d8dc284b1c76cfe1b17fa0acbd6094d8 Author: Christian Brabandt <cb@256bit.org> Date: Thu Nov 23 20:14:28 2023 +0100 patch 9.0.2123: Problem with initializing the length of range() lists Problem: Problem with initializing the length of range() lists Solution: Set length explicitly when it shouldn't contain any items range() may cause a wrong calculation of list length, which may later then cause a segfault in list_find(). This is usually not a problem, because range_list_materialize() calculates the length, when it materializes the list. In addition, in list_find() when the length of the range was wrongly initialized, it may seem to be valid, so the check for list index out-of-bounds will not be true, because it is called before the list is actually materialized. And so we may eventually try to access a null pointer, causing a segfault. So this patch does 3 things: - In f_range(), when we know that the list should be empty, explicitly set the list->lv_len value to zero. This should happen, when start is larger than end (in case the stride is positive) or end is larger than start when the stride is negative. This should fix the underlying issue properly. However, - as a safety measure, let's check that the requested index is not out of range one more time, after the list has been materialized and return NULL in case it suddenly is. - add a few more tests to verify the behaviour. fixes: #13557 closes: #13563 Co-authored-by: Tim Pope <tpope@github.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
author Christian Brabandt <cb@256bit.org>
date Thu, 23 Nov 2023 20:30:07 +0100
parents 0303182665d5
children
Ignore whitespace changes - Everywhere: Within whitespace: At end of lines:
rev   line source
7
3fc0f57ecb91 updated for version 7.0001
vimboss
parents:
diff changeset
1 " Vim indent file
6823
0303182665d5 Updated runtime files.
Bram Moolenaar <bram@vim.org>
parents: 856
diff changeset
2 " Language: Zsh shell script
0303182665d5 Updated runtime files.
Bram Moolenaar <bram@vim.org>
parents: 856
diff changeset
3 " Maintainer: Christian Brabandt <cb@256bit.org>
0303182665d5 Updated runtime files.
Bram Moolenaar <bram@vim.org>
parents: 856
diff changeset
4 " Previous Maintainer: Nikolai Weibull <now@bitwi.se>
0303182665d5 Updated runtime files.
Bram Moolenaar <bram@vim.org>
parents: 856
diff changeset
5 " Latest Revision: 2015-05-29
0303182665d5 Updated runtime files.
Bram Moolenaar <bram@vim.org>
parents: 856
diff changeset
6 " License: Vim (see :h license)
0303182665d5 Updated runtime files.
Bram Moolenaar <bram@vim.org>
parents: 856
diff changeset
7 " Repository: https://github.com/chrisbra/vim-zsh
375
f14cbd913415 updated for version 7.0097
vimboss
parents: 7
diff changeset
8
f14cbd913415 updated for version 7.0097
vimboss
parents: 7
diff changeset
9 if exists("b:did_indent")
f14cbd913415 updated for version 7.0097
vimboss
parents: 7
diff changeset
10 finish
f14cbd913415 updated for version 7.0097
vimboss
parents: 7
diff changeset
11 endif
7
3fc0f57ecb91 updated for version 7.0001
vimboss
parents:
diff changeset
12
3fc0f57ecb91 updated for version 7.0001
vimboss
parents:
diff changeset
13 " Same as sh indenting for now.
3fc0f57ecb91 updated for version 7.0001
vimboss
parents:
diff changeset
14 runtime! indent/sh.vim