annotate .codecov.yml @ 33815:08f9e1eac4cf v9.0.2123

patch 9.0.2123: Problem with initializing the length of range() lists Commit: https://github.com/vim/vim/commit/df63da98d8dc284b1c76cfe1b17fa0acbd6094d8 Author: Christian Brabandt <cb@256bit.org> Date: Thu Nov 23 20:14:28 2023 +0100 patch 9.0.2123: Problem with initializing the length of range() lists Problem: Problem with initializing the length of range() lists Solution: Set length explicitly when it shouldn't contain any items range() may cause a wrong calculation of list length, which may later then cause a segfault in list_find(). This is usually not a problem, because range_list_materialize() calculates the length, when it materializes the list. In addition, in list_find() when the length of the range was wrongly initialized, it may seem to be valid, so the check for list index out-of-bounds will not be true, because it is called before the list is actually materialized. And so we may eventually try to access a null pointer, causing a segfault. So this patch does 3 things: - In f_range(), when we know that the list should be empty, explicitly set the list->lv_len value to zero. This should happen, when start is larger than end (in case the stride is positive) or end is larger than start when the stride is negative. This should fix the underlying issue properly. However, - as a safety measure, let's check that the requested index is not out of range one more time, after the list has been materialized and return NULL in case it suddenly is. - add a few more tests to verify the behaviour. fixes: #13557 closes: #13563 Co-authored-by: Tim Pope <tpope@github.com> Signed-off-by: Christian Brabandt <cb@256bit.org>
author Christian Brabandt <cb@256bit.org>
date Thu, 23 Nov 2023 20:30:07 +0100
parents 0b8312c5dfe0
children
Ignore whitespace changes - Everywhere: Within whitespace: At end of lines:
rev   line source
23608
3b378f03f713 patch 8.2.2346: Codecov reports every little coverage drop
Bram Moolenaar <Bram@vim.org>
parents:
diff changeset
1 coverage:
3b378f03f713 patch 8.2.2346: Codecov reports every little coverage drop
Bram Moolenaar <Bram@vim.org>
parents:
diff changeset
2 range: "80...100"
3b378f03f713 patch 8.2.2346: Codecov reports every little coverage drop
Bram Moolenaar <Bram@vim.org>
parents:
diff changeset
3 status:
3b378f03f713 patch 8.2.2346: Codecov reports every little coverage drop
Bram Moolenaar <Bram@vim.org>
parents:
diff changeset
4 project:
3b378f03f713 patch 8.2.2346: Codecov reports every little coverage drop
Bram Moolenaar <Bram@vim.org>
parents:
diff changeset
5 default:
3b378f03f713 patch 8.2.2346: Codecov reports every little coverage drop
Bram Moolenaar <Bram@vim.org>
parents:
diff changeset
6 threshold: 0.05%
28759
8bb342f944d3 patch 8.2.4904: codecov includes MS-Windows install files
Bram Moolenaar <Bram@vim.org>
parents: 23608
diff changeset
7
33463
0b8312c5dfe0 patch 9.0.1985: CI: codecov is intrusive
Christian Brabandt <cb@256bit.org>
parents: 28761
diff changeset
8 comment: false
0b8312c5dfe0 patch 9.0.1985: CI: codecov is intrusive
Christian Brabandt <cb@256bit.org>
parents: 28761
diff changeset
9
28759
8bb342f944d3 patch 8.2.4904: codecov includes MS-Windows install files
Bram Moolenaar <Bram@vim.org>
parents: 23608
diff changeset
10 # Files not run by tests
8bb342f944d3 patch 8.2.4904: codecov includes MS-Windows install files
Bram Moolenaar <Bram@vim.org>
parents: 23608
diff changeset
11 ignore:
8bb342f944d3 patch 8.2.4904: codecov includes MS-Windows install files
Bram Moolenaar <Bram@vim.org>
parents: 23608
diff changeset
12 - "src/dosinst.c"
28761
035fbd9bd1c6 patch 8.2.4905: codecov includes MS-Windows install header file
Bram Moolenaar <Bram@vim.org>
parents: 28759
diff changeset
13 - "src/dosinst.h"
28759
8bb342f944d3 patch 8.2.4904: codecov includes MS-Windows install files
Bram Moolenaar <Bram@vim.org>
parents: 23608
diff changeset
14 - "src/uninstall.c"