annotate READMEdir/README_amisrc.txt @ 33664:06b59278bfcf v9.0.2070

patch 9.0.2070: [security] disallow setting env in restricted mode Commit: https://github.com/vim/vim/commit/6b89dd6a7257a1e2e9c7ea070b407bc4674a5118 Author: Christian Brabandt <cb@256bit.org> Date: Thu Oct 26 22:14:17 2023 +0200 patch 9.0.2070: [security] disallow setting env in restricted mode Problem: [security] disallow setting env in restricted mode Solution: Setting environment variables in restricted mode could potentially be used to execute shell commands. Disallow this. restricted mode: disable allow setting of environment variables Setting environment variables in restricted mode, may have some unwanted consequences. So, for example by setting $GCONV_PATH in restricted mode and then calling the iconv() function, one may be able to execute some unwanted payload, because the `iconv_open()` function internally uses the `$GCONV_PATH` variable to find its conversion data. So let's disable setting environment variables, even so this is no complete protection, since we are not clearing the existing environment. I tried a few ways but wasn't successful :( One could also argue to disable the iconv() function completely in restricted mode, but who knows what other API functions can be influenced by setting some other unrelated environment variables. So let's leave it as it is currently. closes: #13394 See: https://huntr.com/bounties/b0a2eda1-459c-4e36-98e6-0cc7d7faccfe/ Signed-off-by: Christian Brabandt <cb@256bit.org>
author Christian Brabandt <cb@256bit.org>
date Thu, 26 Oct 2023 22:30:03 +0200
parents f8116058ca76
children 4635e43f2c6f
Ignore whitespace changes - Everywhere: Within whitespace: At end of lines:
rev   line source
29314
f8116058ca76 release version 9.0
Bram Moolenaar <Bram@vim.org>
parents: 18879
diff changeset
1 README_amisrc.txt for version 9.0 of Vim: Vi IMproved.
8623
58e749232bd7 commit https://github.com/vim/vim/commit/818c9e7edfce339eff7cb357f2ec29a72afd1977
Christian Brabandt <cb@256bit.org>
parents:
diff changeset
2
58e749232bd7 commit https://github.com/vim/vim/commit/818c9e7edfce339eff7cb357f2ec29a72afd1977
Christian Brabandt <cb@256bit.org>
parents:
diff changeset
3 See "README.txt" for general information about Vim.
58e749232bd7 commit https://github.com/vim/vim/commit/818c9e7edfce339eff7cb357f2ec29a72afd1977
Christian Brabandt <cb@256bit.org>
parents:
diff changeset
4 See "README_ami.txt" for installation instructions for the Amiga.
29314
f8116058ca76 release version 9.0
Bram Moolenaar <Bram@vim.org>
parents: 18879
diff changeset
5 These files are in the runtime archive (vim90rt.tgz).
8623
58e749232bd7 commit https://github.com/vim/vim/commit/818c9e7edfce339eff7cb357f2ec29a72afd1977
Christian Brabandt <cb@256bit.org>
parents:
diff changeset
6
58e749232bd7 commit https://github.com/vim/vim/commit/818c9e7edfce339eff7cb357f2ec29a72afd1977
Christian Brabandt <cb@256bit.org>
parents:
diff changeset
7
58e749232bd7 commit https://github.com/vim/vim/commit/818c9e7edfce339eff7cb357f2ec29a72afd1977
Christian Brabandt <cb@256bit.org>
parents:
diff changeset
8 The Amiga source archive contains the files needed to compile Vim on the
58e749232bd7 commit https://github.com/vim/vim/commit/818c9e7edfce339eff7cb357f2ec29a72afd1977
Christian Brabandt <cb@256bit.org>
parents:
diff changeset
9 Amiga.
58e749232bd7 commit https://github.com/vim/vim/commit/818c9e7edfce339eff7cb357f2ec29a72afd1977
Christian Brabandt <cb@256bit.org>
parents:
diff changeset
10
58e749232bd7 commit https://github.com/vim/vim/commit/818c9e7edfce339eff7cb357f2ec29a72afd1977
Christian Brabandt <cb@256bit.org>
parents:
diff changeset
11 See "src/INSTALLami.txt" for instructions on how to compile Vim on the Amiga.