Mercurial > vim
annotate .codecov.yml @ 33664:06b59278bfcf v9.0.2070
patch 9.0.2070: [security] disallow setting env in restricted mode
Commit: https://github.com/vim/vim/commit/6b89dd6a7257a1e2e9c7ea070b407bc4674a5118
Author: Christian Brabandt <cb@256bit.org>
Date: Thu Oct 26 22:14:17 2023 +0200
patch 9.0.2070: [security] disallow setting env in restricted mode
Problem: [security] disallow setting env in restricted mode
Solution: Setting environment variables in restricted mode could
potentially be used to execute shell commands. Disallow this.
restricted mode: disable allow setting of environment variables
Setting environment variables in restricted mode, may have some unwanted
consequences. So, for example by setting $GCONV_PATH in restricted mode
and then calling the iconv() function, one may be able to execute some
unwanted payload, because the `iconv_open()` function internally uses
the `$GCONV_PATH` variable to find its conversion data.
So let's disable setting environment variables, even so this is no
complete protection, since we are not clearing the existing environment.
I tried a few ways but wasn't successful :(
One could also argue to disable the iconv() function completely in
restricted mode, but who knows what other API functions can be
influenced by setting some other unrelated environment variables.
So let's leave it as it is currently.
closes: #13394
See: https://huntr.com/bounties/b0a2eda1-459c-4e36-98e6-0cc7d7faccfe/
Signed-off-by: Christian Brabandt <cb@256bit.org>
author | Christian Brabandt <cb@256bit.org> |
---|---|
date | Thu, 26 Oct 2023 22:30:03 +0200 |
parents | 0b8312c5dfe0 |
children |
rev | line source |
---|---|
23608
3b378f03f713
patch 8.2.2346: Codecov reports every little coverage drop
Bram Moolenaar <Bram@vim.org>
parents:
diff
changeset
|
1 coverage: |
3b378f03f713
patch 8.2.2346: Codecov reports every little coverage drop
Bram Moolenaar <Bram@vim.org>
parents:
diff
changeset
|
2 range: "80...100" |
3b378f03f713
patch 8.2.2346: Codecov reports every little coverage drop
Bram Moolenaar <Bram@vim.org>
parents:
diff
changeset
|
3 status: |
3b378f03f713
patch 8.2.2346: Codecov reports every little coverage drop
Bram Moolenaar <Bram@vim.org>
parents:
diff
changeset
|
4 project: |
3b378f03f713
patch 8.2.2346: Codecov reports every little coverage drop
Bram Moolenaar <Bram@vim.org>
parents:
diff
changeset
|
5 default: |
3b378f03f713
patch 8.2.2346: Codecov reports every little coverage drop
Bram Moolenaar <Bram@vim.org>
parents:
diff
changeset
|
6 threshold: 0.05% |
28759
8bb342f944d3
patch 8.2.4904: codecov includes MS-Windows install files
Bram Moolenaar <Bram@vim.org>
parents:
23608
diff
changeset
|
7 |
33463
0b8312c5dfe0
patch 9.0.1985: CI: codecov is intrusive
Christian Brabandt <cb@256bit.org>
parents:
28761
diff
changeset
|
8 comment: false |
0b8312c5dfe0
patch 9.0.1985: CI: codecov is intrusive
Christian Brabandt <cb@256bit.org>
parents:
28761
diff
changeset
|
9 |
28759
8bb342f944d3
patch 8.2.4904: codecov includes MS-Windows install files
Bram Moolenaar <Bram@vim.org>
parents:
23608
diff
changeset
|
10 # Files not run by tests |
8bb342f944d3
patch 8.2.4904: codecov includes MS-Windows install files
Bram Moolenaar <Bram@vim.org>
parents:
23608
diff
changeset
|
11 ignore: |
8bb342f944d3
patch 8.2.4904: codecov includes MS-Windows install files
Bram Moolenaar <Bram@vim.org>
parents:
23608
diff
changeset
|
12 - "src/dosinst.c" |
28761
035fbd9bd1c6
patch 8.2.4905: codecov includes MS-Windows install header file
Bram Moolenaar <Bram@vim.org>
parents:
28759
diff
changeset
|
13 - "src/dosinst.h" |
28759
8bb342f944d3
patch 8.2.4904: codecov includes MS-Windows install files
Bram Moolenaar <Bram@vim.org>
parents:
23608
diff
changeset
|
14 - "src/uninstall.c" |