Mercurial > vim
changeset 28495:f285dd00704e v8.2.4772
patch 8.2.4772: old Coverity warning for not checking ftell() return value
Commit: https://github.com/vim/vim/commit/3df8f6e353eeaf24bb5fe3769ed07c03791bb58e
Author: Bram Moolenaar <Bram@vim.org>
Date: Sun Apr 17 14:01:51 2022 +0100
patch 8.2.4772: old Coverity warning for not checking ftell() return value
Problem: Old Coverity warning for not checking ftell() return value.
Solution: Check return value of fseek() and ftell().
| author | Bram Moolenaar <Bram@vim.org> |
|---|---|
| date | Sun, 17 Apr 2022 15:15:03 +0200 |
| parents | 6a015080f040 |
| children | bf19917b91ab |
| files | src/misc1.c src/version.c |
| diffstat | 2 files changed, 10 insertions(+), 6 deletions(-) [+] |
line wrap: on
line diff
--- a/src/misc1.c +++ b/src/misc1.c @@ -2337,16 +2337,18 @@ get_cmd_output( fd = mch_fopen((char *)tempname, READBIN); # endif - if (fd == NULL) + // Not being able to seek means we can't read the file. + if (fd == NULL + || fseek(fd, 0L, SEEK_END) == -1 + || (len = ftell(fd)) == -1 // get size of temp file + || fseek(fd, 0L, SEEK_SET) == -1) // back to the start { - semsg(_(e_cant_open_file_str), tempname); + semsg(_(e_cannot_read_from_str), tempname); + if (fd != NULL) + fclose(fd); goto done; } - fseek(fd, 0L, SEEK_END); - len = ftell(fd); // get size of temp file - fseek(fd, 0L, SEEK_SET); - buffer = alloc(len + 1); if (buffer != NULL) i = (int)fread((char *)buffer, (size_t)1, (size_t)len, fd);