changeset 25917:79a5c8238a5d v8.2.3492

patch 8.2.3492: crash when pasting too many times Commit: https://github.com/vim/vim/commit/eeed1c7ae090c17f4df51cf97b2a9e4d8b4f4dc7 Author: Bram Moolenaar <Bram@vim.org> Date: Sun Oct 10 12:35:17 2021 +0100 patch 8.2.3492: crash when pasting too many times Problem: Crash when pasting too many times. Solution: Limit the size to what fits in an int. (closes https://github.com/vim/vim/issues/8962)
author Bram Moolenaar <Bram@vim.org>
date Sun, 10 Oct 2021 13:45:04 +0200
parents 52792b298baf
children 0cdb470bf8f7
files src/errors.h src/register.c src/testdir/test_put.vim src/version.c
diffstat 4 files changed, 21 insertions(+), 2 deletions(-) [+]
line wrap: on
line diff
--- a/src/errors.h
+++ b/src/errors.h
@@ -664,3 +664,5 @@ EXTERN char e_blob_required_for_argument
 	INIT(= N_("E1238: Blob required for argument %d"));
 EXTERN char e_invalid_value_for_blob_nr[]
 	INIT(= N_("E1239: Invalid value for blob: %d"));
+EXTERN char e_resulting_text_too_long[]
+	INIT(= N_("E1240: Resulting text too long"));
--- a/src/register.c
+++ b/src/register.c
@@ -2011,8 +2011,15 @@ do_put(
 	    }
 
 	    do {
-		totlen = count * yanklen;
-		if (totlen > 0)
+		long multlen = count * yanklen;
+
+		totlen = multlen;
+		if (totlen != multlen)
+		{
+		    emsg(_(e_resulting_text_too_long));
+		    break;
+		}
+		else if (totlen > 0)
 		{
 		    oldp = ml_get(lnum);
 		    if (lnum > start_lnum)
--- a/src/testdir/test_put.vim
+++ b/src/testdir/test_put.vim
@@ -134,4 +134,12 @@ func Test_gp_with_count_leaves_cursor_at
   bwipe!
 endfunc
 
+func Test_very_larg_count()
+  new
+  let @" = 'x'
+  call assert_fails('norm 44444444444444p', 'E1240:')
+  bwipe!
+endfunc
+
+
 " vim: shiftwidth=2 sts=2 expandtab
--- a/src/version.c
+++ b/src/version.c
@@ -758,6 +758,8 @@ static char *(features[]) =
 static int included_patches[] =
 {   /* Add new patch number below this line */
 /**/
+    3492,
+/**/
     3491,
 /**/
     3490,