Mercurial > vim

changeset 19605:5ad7a406647a v8.2.0359

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
patch 8.2.0359: popup_atcursor() may hang Commit: https://github.com/vim/vim/commit/ba2920fe976b37326933afa820616523b509495f Author: Bram Moolenaar <Bram@vim.org> Date: Fri Mar 6 21:43:17 2020 +0100 patch 8.2.0359: popup_atcursor() may hang Problem: popup_atcursor() may hang. (Yasuhiro Matsumoto) Solution: Take the decoration into account. (closes https://github.com/vim/vim/issues/5728)
author Bram Moolenaar <Bram@vim.org>
date Fri, 06 Mar 2020 21:45:03 +0100
parents 5ca07850fef0
children 53ee30ecdacf
files src/popupwin.c src/testdir/test_popupwin.vim src/version.c
diffstat 3 files changed, 18 insertions(+), 2 deletions(-) [+]
line wrap: on
line diff
--- a/src/popupwin.c
+++ b/src/popupwin.c
@@ -1232,8 +1232,9 @@ popup_adjust_position(win_T *wp)
 		|| wp->w_popup_pos == POPPOS_BOTLEFT))
 	{
 	    wp->w_wincol = wantcol - 1;
-	    if (wp->w_wincol >= Columns - 1)
-		wp->w_wincol = Columns - 1;
+	    // Need to see at least one character after the decoration.
+	    if (wp->w_wincol > Columns - left_extra - 1)
+		wp->w_wincol = Columns - left_extra - 1;
 	}
     }
 
--- a/src/testdir/test_popupwin.vim
+++ b/src/testdir/test_popupwin.vim
@@ -3293,4 +3293,17 @@ func Test_popupwin_filter_input_multibyt
   unlet g:bytes
 endfunc
 
+func Test_popupwin_atcursor_far_right()
+  new
+
+  " this was getting stuck
+  set signcolumn=yes
+  call setline(1, repeat('=', &columns))
+  normal! ggg$
+  call popup_atcursor(repeat('x', 500), #{moved: 'any', border: []})
+
+  bwipe!
+  set signcolumn&
+endfunc
+
 " vim: shiftwidth=2 sts=2
--- a/src/version.c
+++ b/src/version.c
@@ -739,6 +739,8 @@ static char *(features[]) =
 static int included_patches[] =
 {   /* Add new patch number below this line */
 /**/
+    359,
+/**/
     358,
 /**/
     357,