Mercurial > vim
changeset 19223:173b99509038 v8.2.0170
patch 8.2.0170: Coverity warning for ignoring return value
Commit: https://github.com/vim/vim/commit/a6d536829a2c3151f3d0faa0ecdc7b8230fb11ec
Author: Bram Moolenaar <Bram@vim.org>
Date: Tue Jan 28 23:04:06 2020 +0100
patch 8.2.0170: Coverity warning for ignoring return value
Problem: Coverity warning for ignoring return value.
Solution: Check the return value and return if failed.
| author | Bram Moolenaar <Bram@vim.org> |
|---|---|
| date | Tue, 28 Jan 2020 23:15:03 +0100 |
| parents | 7bf13c862e20 |
| children | 743c2d8e09bd |
| files | src/version.c src/vim9compile.c |
| diffstat | 2 files changed, 7 insertions(+), 2 deletions(-) [+] |
line wrap: on
line diff
--- a/src/version.c +++ b/src/version.c @@ -743,6 +743,8 @@ static char *(features[]) = static int included_patches[] = { /* Add new patch number below this line */ /**/ + 170, +/**/ 169, /**/ 168,
--- a/src/vim9compile.c +++ b/src/vim9compile.c @@ -2917,7 +2917,8 @@ compile_expr1(char_u **arg, cctx_T *cct // evaluate the second expression; any type is accepted *arg = skipwhite(p + 1); - compile_expr1(arg, cctx); + if (compile_expr1(arg, cctx) == FAIL) + return FAIL; // remember the type and drop it --stack->ga_len; @@ -2942,7 +2943,8 @@ compile_expr1(char_u **arg, cctx_T *cct // evaluate the third expression *arg = skipwhite(p + 1); - compile_expr1(arg, cctx); + if (compile_expr1(arg, cctx) == FAIL) + return FAIL; // If the types differ, the result has a more generic type. type2 = ((type_T **)stack->ga_data)[stack->ga_len - 1]; @@ -3265,6 +3267,7 @@ compile_assignment(char_u *arg, exarg_T if (*op != '=') { if (option) + // TODO: check the option exists generate_LOAD(cctx, ISN_LOADOPT, 0, name + 1, type); else if (global) generate_LOAD(cctx, ISN_LOADG, 0, name + 2, type);