changeset 18793:7a1606ceec7d v8.1.2385

patch 8.1.2385: opening cmdline window with feedkeys() does not work Commit: https://github.com/vim/vim/commit/85db5475982e166ec5bb1c8c9a5c8bf062d49ed1 Author: Bram Moolenaar <Bram@vim.org> Date: Wed Dec 4 15:11:08 2019 +0100 patch 8.1.2385: opening cmdline window with feedkeys() does not work Problem: Opening cmdline window with feedkeys() does not work. (Yegappan Lakshmanan) Solution: Recognize K_CMDWIN also when ex_normal_busy is set.
author Bram Moolenaar <Bram@vim.org>
date Wed, 04 Dec 2019 15:15:04 +0100
parents af365376638e
children 99f9d7930215
files src/ex_getln.c src/testdir/test_cmdline.vim src/version.c
diffstat 3 files changed, 9 insertions(+), 1 deletions(-) [+]
line wrap: on
line diff
--- a/src/ex_getln.c
+++ b/src/ex_getln.c
@@ -1361,7 +1361,8 @@ getcmdline_int(
 #ifdef FEAT_CMDWIN
 	if (c == cedit_key || c == K_CMDWIN)
 	{
-	    if (ex_normal_busy == 0 && got_int == FALSE)
+	    // TODO: why is ex_normal_busy checked here?
+	    if ((c == K_CMDWIN || ex_normal_busy == 0) && got_int == FALSE)
 	    {
 		/*
 		 * Open a window to edit the command line (and history).
--- a/src/testdir/test_cmdline.vim
+++ b/src/testdir/test_cmdline.vim
@@ -843,3 +843,8 @@ func Test_buffers_lastused()
   bwipeout bufb
   bwipeout bufc
 endfunc
+
+func Test_cmdwin_feedkeys()
+  " This should not generate E488
+  call feedkeys("q:\<CR>", 'x')
+endfunc
--- a/src/version.c
+++ b/src/version.c
@@ -743,6 +743,8 @@ static char *(features[]) =
 static int included_patches[] =
 {   /* Add new patch number below this line */
 /**/
+    2385,
+/**/
     2384,
 /**/
     2383,