Mercurial > vim
changeset 17037:9297877074a3 v8.1.1518
patch 8.1.1518: crash when setting 'columns' while a popup is visible
commit https://github.com/vim/vim/commit/202d982b36d87cf91d992bd7e30d3223bdc72cd9
Author: Bram Moolenaar <Bram@vim.org>
Date: Tue Jun 11 21:56:30 2019 +0200
patch 8.1.1518: crash when setting 'columns' while a popup is visible
Problem: Crash when setting 'columns' while a popup is visible.
Solution: Recompute all positions when clearing the screen. (closes https://github.com/vim/vim/issues/4467)
| author | Bram Moolenaar <Bram@vim.org> |
|---|---|
| date | Tue, 11 Jun 2019 22:00:07 +0200 |
| parents | 235cbf491430 |
| children | 3f2ac157af87 |
| files | src/screen.c src/testdir/dumps/Test_popupwin_04a.dump src/testdir/test_popupwin.vim src/version.c |
| diffstat | 4 files changed, 29 insertions(+), 3 deletions(-) [+] |
line wrap: on
line diff
--- a/src/screen.c +++ b/src/screen.c @@ -1029,9 +1029,16 @@ may_update_popup_mask(int type) win_T *wp; short *mask; int line, col; - - if (popup_mask_tab != curtab) + int redraw_all = FALSE; + + // Need to recompute when switching tabs. + // Also recompute when the type is CLEAR or NOT_VALID, something basic + // (such as the screen size) must have changed. + if (popup_mask_tab != curtab || type >= NOT_VALID) + { popup_mask_refresh = TRUE; + redraw_all = TRUE; + } if (!popup_mask_refresh) { // Check if any buffer has changed. @@ -1070,7 +1077,8 @@ may_update_popup_mask(int type) popup_visible = TRUE; // Recompute the position if the text changed. - if (wp->w_popup_last_changedtick != CHANGEDTICK(wp->w_buffer)) + if (redraw_all + || wp->w_popup_last_changedtick != CHANGEDTICK(wp->w_buffer)) popup_adjust_position(wp); // the width and height are for the inside, add the padding and
new file mode 100644 --- /dev/null +++ b/src/testdir/dumps/Test_popupwin_04a.dump @@ -0,0 +1,10 @@ +> +0&#ffffff0@11 +|~+0#4040ff13&| @10 +|~| @10 +|~| @6|o+0#0000001#ffd7ff255|t|h|e +|~+0#4040ff13#ffffff0| @6|r+0#0000001#ffd7ff255| |t|a +|~+0#4040ff13#ffffff0| @6|b+0#0000001#ffd7ff255| @2 +|~+0#4040ff13#ffffff0| @6|a+0#0000001#ffd7ff255| |c+0#ff404010&|o +|~+0#4040ff13#ffffff0| @6|m+0#ff404010#ffd7ff255@1|e|n +|~+0#4040ff13#ffffff0| @6|t+0#ff404010#ffd7ff255| +0#0000001&|l|i +| +0#0000000#ffffff0@5|0|,|n+0#0000001#ffd7ff255|e| @1
--- a/src/testdir/test_popupwin.vim +++ b/src/testdir/test_popupwin.vim @@ -41,6 +41,12 @@ func Test_simple_popup() call term_sendkeys(buf, ":quit!\<CR>") call VerifyScreenDump(buf, 'Test_popupwin_04', {}) + " set 'columns' to a small value, size must be recomputed + call term_sendkeys(buf, ":let cols = &columns\<CR>") + call term_sendkeys(buf, ":set columns=12\<CR>") + call VerifyScreenDump(buf, 'Test_popupwin_04a', {}) + call term_sendkeys(buf, ":let &columns = cols\<CR>") + " resize popup, show empty line at bottom call term_sendkeys(buf, ":call popup_move(popupwin, {'minwidth': 15, 'maxwidth': 25, 'minheight': 3, 'maxheight': 5})\<CR>") call term_sendkeys(buf, ":redraw\<CR>")