Mercurial > vim
changeset 13105:bfa7f5b23c53 v8.0.1427
patch 8.0.1427: the :leftabove modifier doesn't work for :copen
commit https://github.com/vim/vim/commit/de04654ddc865af94ef04b1738b335a924be7923
Author: Bram Moolenaar <Bram@vim.org>
Date: Tue Dec 26 13:53:11 2017 +0100
patch 8.0.1427: the :leftabove modifier doesn't work for :copen
Problem: The :leftabove modifier doesn't work for :copen.
Solution: Respect the split modifier. (Yegappan Lakshmanan, closes https://github.com/vim/vim/issues/2496)
| author | Christian Brabandt <cb@256bit.org> |
|---|---|
| date | Tue, 26 Dec 2017 14:00:05 +0100 |
| parents | 99199df277c0 |
| children | 50a2bb503137 |
| files | src/quickfix.c src/testdir/test_quickfix.vim src/version.c |
| diffstat | 3 files changed, 37 insertions(+), 2 deletions(-) [+] |
line wrap: on
line diff
--- a/src/quickfix.c +++ b/src/quickfix.c @@ -3222,6 +3222,8 @@ ex_copen(exarg_T *eap) } else { + int flags = 0; + qf_buf = qf_find_buf(qi); /* The current window becomes the previous window afterwards. */ @@ -3229,10 +3231,14 @@ ex_copen(exarg_T *eap) if ((eap->cmdidx == CMD_copen || eap->cmdidx == CMD_cwindow) && cmdmod.split == 0) - /* Create the new window at the very bottom, except when + /* Create the new quickfix window at the very bottom, except when * :belowright or :aboveleft is used. */ win_goto(lastwin); - if (win_split(height, WSP_BELOW | WSP_NEWLOC) == FAIL) + /* Default is to open the window below the current window */ + if (cmdmod.split == 0) + flags = WSP_BELOW; + flags |= WSP_NEWLOC; + if (win_split(height, flags) == FAIL) return; /* not enough room for window */ RESET_BINDING(curwin);
--- a/src/testdir/test_quickfix.vim +++ b/src/testdir/test_quickfix.vim @@ -3078,3 +3078,30 @@ func Test_lvimgrep_crash() augroup END enew | only endfunc + +" Test for the position of the quickfix and location list window +func Test_qfwin_pos() + " Open two windows + new | only + new + cexpr ['F1:10:L10'] + copen + " Quickfix window should be the bottom most window + call assert_equal(3, winnr()) + close + " Open at the very top + wincmd t + topleft copen + call assert_equal(1, winnr()) + close + " open left of the current window + wincmd t + below new + leftabove copen + call assert_equal(2, winnr()) + close + " open right of the current window + rightbelow copen + call assert_equal(3, winnr()) + close +endfunc