Mercurial > vim
changeset 28177:f04a3ec65e2d v8.2.4614
patch 8.2.4614: redrawing too much when 'cursorline' is set
Commit: https://github.com/vim/vim/commit/c20e46a4e3efcd408ef132872238144ea34f7ae5
Author: zeertzjq <zeertzjq@outlook.com>
Date: Wed Mar 23 14:55:23 2022 +0000
patch 8.2.4614: redrawing too much when 'cursorline' is set
Problem: Redrawing too much when 'cursorline' is set and jumping around.
Solution: Rely on win_update() to redraw the current and previous cursor
line, do not mark lines as modified. (closes #9996)
author | Bram Moolenaar <Bram@vim.org> |
---|---|
date | Wed, 23 Mar 2022 16:00:03 +0100 |
parents | a394011bde90 |
children | 96d002169529 |
files | src/drawline.c src/drawscreen.c src/move.c src/option.c src/proto/move.pro src/version.c |
diffstat | 6 files changed, 13 insertions(+), 43 deletions(-) [+] |
line wrap: on
line diff
--- a/src/drawline.c +++ b/src/drawline.c @@ -945,8 +945,7 @@ win_line( if (wp->w_p_cul && lnum == wp->w_cursor.lnum) { // Do not show the cursor line in the text when Visual mode is active, - // because it's not clear what is selected then. Do update - // w_last_cursorline. + // because it's not clear what is selected then. if (!(wp == curwin && VIsual_active) && wp->w_p_culopt_flags != CULOPT_NBR) { @@ -971,18 +970,14 @@ win_line( else # endif line_attr = cul_attr; - wp->w_last_cursorline = wp->w_cursor.lnum; } else { line_attr_save = line_attr; - wp->w_last_cursorline = 0; margin_columns_win(wp, &left_curline_col, &right_curline_col); } area_highlighting = TRUE; } - else - wp->w_last_cursorline = wp->w_cursor.lnum; } #endif
--- a/src/drawscreen.c +++ b/src/drawscreen.c @@ -1468,9 +1468,6 @@ win_update(win_T *wp) # define DID_FOLD 3 // updated a folded line int did_update = DID_NONE; linenr_T syntax_last_parsed = 0; // last parsed text line - // remember the current w_last_cursorline, it changes when drawing the new - // cursor line - linenr_T last_cursorline = wp->w_last_cursorline; #endif linenr_T mod_top = 0; linenr_T mod_bot = 0; @@ -2245,8 +2242,8 @@ win_update(win_T *wp) #endif )))) #ifdef FEAT_SYN_HL - || (wp->w_p_cul && (lnum == wp->w_cursor.lnum - || lnum == last_cursorline)) + || (wp->w_p_cul && lnum == wp->w_cursor.lnum) + || lnum == wp->w_last_cursorline #endif ) { @@ -2551,6 +2548,12 @@ win_update(win_T *wp) // End of loop over all window lines. +#ifdef FEAT_SYN_HL + // Now that the window has been redrawn with the old and new cursor line, + // update w_last_cursorline. + wp->w_last_cursorline = wp->w_p_cul ? wp->w_cursor.lnum : 0; +#endif + #ifdef FEAT_VTP // Rewrite the character at the end of the screen line. // See the version that was fixed.
--- a/src/move.c +++ b/src/move.c @@ -115,14 +115,6 @@ comp_botline(win_T *wp) set_empty_rows(wp, done); } -#ifdef FEAT_SYN_HL - void -reset_cursorline(void) -{ - curwin->w_last_cursorline = 0; -} -#endif - /* * Redraw when w_cline_row changes and 'relativenumber' or 'cursorline' is * set. @@ -138,24 +130,8 @@ redraw_for_cursorline(win_T *wp) && (wp->w_valid & VALID_CROW) == 0 && !pum_visible()) { - if (wp->w_p_rnu) - // win_line() will redraw the number column only. - redraw_win_later(wp, VALID); -#ifdef FEAT_SYN_HL - if (wp->w_p_cul) - { - if (wp->w_redr_type <= VALID && wp->w_last_cursorline != 0) - { - // "w_last_cursorline" may be outdated, worst case we redraw - // too much. This is optimized for moving the cursor around in - // the current window. - redrawWinline(wp, wp->w_last_cursorline); - redrawWinline(wp, wp->w_cursor.lnum); - } - else - redraw_win_later(wp, SOME_VALID); - } -#endif + // win_line() will redraw the number column and cursorline only. + redraw_win_later(wp, VALID); } }
--- a/src/option.c +++ b/src/option.c @@ -2782,11 +2782,6 @@ set_bool_option( p_lrm = !p_lnr; #endif -#ifdef FEAT_SYN_HL - else if ((int *)varp == &curwin->w_p_cul && !value && old_value) - reset_cursorline(); -#endif - #ifdef FEAT_PERSISTENT_UNDO // 'undofile' else if ((int *)varp == &curbuf->b_p_udf || (int *)varp == &p_udf)