Mercurial > vim
changeset 19744:eb4887dd4b60 v8.2.0428
patch 8.2.0428: buffer name may leak
Commit: https://github.com/vim/vim/commit/d5bc32df207eae408263ae6ab737771365d0bca1
Author: Bram Moolenaar <Bram@vim.org>
Date: Sun Mar 22 19:25:50 2020 +0100
patch 8.2.0428: buffer name may leak
Problem: Buffer name may leak.
Solution: Free the buffer name before overwriting it.
author | Bram Moolenaar <Bram@vim.org> |
---|---|
date | Sun, 22 Mar 2020 19:30:04 +0100 |
parents | 456d9eee3c81 |
children | 7a9b0a54964b |
files | src/terminal.c src/version.c |
diffstat | 2 files changed, 12 insertions(+), 2 deletions(-) [+] |
line wrap: on
line diff
--- a/src/terminal.c +++ b/src/terminal.c @@ -465,7 +465,7 @@ term_start( buf_T *buf; // Create a new buffer without a window. Make it the current buffer for - // a moment to be able to do the initialisations. + // a moment to be able to do the initializations. buf = buflist_new((char_u *)"", NULL, (linenr_T)0, BLN_NEW | BLN_LISTED); if (buf == NULL || ml_open(buf) == FAIL) @@ -526,9 +526,15 @@ term_start( apply_autocmds(EVENT_BUFFILEPRE, NULL, NULL, FALSE, curbuf); if (opt->jo_term_name != NULL) + { + vim_free(curbuf->b_ffname); curbuf->b_ffname = vim_strsave(opt->jo_term_name); + } else if (argv != NULL) + { + vim_free(curbuf->b_ffname); curbuf->b_ffname = vim_strsave((char_u *)"!system"); + } else { int i; @@ -1983,7 +1989,7 @@ term_enter_job_mode() redraw_buf_and_status_later(curbuf, NOT_VALID); #ifdef FEAT_PROP_POPUP if (WIN_IS_POPUP(curwin)) - redraw_win_later(curwin, NOT_VALID); + redraw_later(NOT_VALID); #endif } @@ -4321,6 +4327,8 @@ term_update_colors(void) vterm_obtain_state(term->tl_vterm), &term->tl_default_color.fg, &term->tl_default_color.bg); + + redraw_later(NOT_VALID); } /*