Mercurial > vim
changeset 12946:eae40b455a72 v8.0.1349
patch 8.0.1349: options test fails when using Motif or GTK GUI
commit https://github.com/vim/vim/commit/17471e84a72b5137a6010a98c4adb780237750db
Author: Bram Moolenaar <Bram@vim.org>
Date: Sun Nov 26 23:47:18 2017 +0100
patch 8.0.1349: options test fails when using Motif or GTK GUI
Problem: Options test fails when using Motif or GTK GUI.
Solution: Use "fixed" instead of "fixedsys" for Unix. Don't try "xxx" for
guifonteset. Don't set 'termencoding' to anything but "utf-8" for
GTK. Give an error if 'termencoding' can't be converted.
| author | Christian Brabandt <cb@256bit.org> |
|---|---|
| date | Mon, 27 Nov 2017 00:00:05 +0100 |
| parents | ffe901f0ba65 |
| children | f3384119229e |
| files | src/option.c src/testdir/gen_opt_test.vim src/version.c |
| diffstat | 3 files changed, 21 insertions(+), 6 deletions(-) [+] |
line wrap: on
line diff
--- a/src/option.c +++ b/src/option.c @@ -6369,8 +6369,13 @@ did_set_string_option( * display output conversion. */ if (((varp == &p_enc && *p_tenc != NUL) || varp == &p_tenc)) { - convert_setup(&input_conv, p_tenc, p_enc); - convert_setup(&output_conv, p_enc, p_tenc); + if (convert_setup(&input_conv, p_tenc, p_enc) == FAIL + || convert_setup(&output_conv, p_enc, p_tenc) == FAIL) + { + EMSG3(_("E950: Cannot convert between %s and %s"), + p_tenc, p_enc); + errmsg = e_invarg; + } } # if defined(WIN3264) && defined(FEAT_MBYTE)
--- a/src/testdir/gen_opt_test.vim +++ b/src/testdir/gen_opt_test.vim @@ -19,6 +19,9 @@ let script = [ /#define p_term let end = line('.') +" font name that works everywhere (hopefully) +let fontname = has('win32') ? 'fixedsys' : 'fixed' + " Two lists with values: values that work and values that fail. " When not listed, "othernum" or "otherstring" is used. let test_values = { @@ -93,8 +96,9 @@ let test_values = { \ 'foldmarker': [['((,))'], ['', 'xxx']], \ 'formatoptions': [['', 'vt', 'v,t'], ['xxx']], \ 'guicursor': [['', 'n:block-Cursor'], ['xxx']], - \ 'guifont': [['', 'fixedsys'], []], - \ 'guifontwide': [['', 'fixedsys'], []], + \ 'guifont': [['', fontname], []], + \ 'guifontwide': [['', fontname], []], + \ 'guifontset': [['', fontname], []], \ 'helplang': [['', 'de', 'de,it'], ['xxx']], \ 'highlight': [['', 'e:Error'], ['xxx']], \ 'imactivatekey': [['', 'S-space'], ['xxx']], @@ -126,6 +130,7 @@ let test_values = { \ 'tagcase': [['smart', 'match'], ['', 'xxx', 'smart,match']], \ 'term': [[], []], \ 'termsize': [['', '24x80', '0x80', '32x0', '0x0'], ['xxx', '80', '8ax9', '24x80b']], + \ 'termencoding': [has('gui_gtk') ? [] : ['', 'utf-8'], ['xxx']], \ 'toolbar': [['', 'icons', 'text'], ['xxx']], \ 'toolbariconsize': [['', 'tiny', 'huge'], ['xxx']], \ 'ttymouse': [['', 'xterm'], ['xxx']], @@ -189,8 +194,11 @@ while 1 call add(script, "endif") endif - call add(script, 'set ' . name . '&') - call add(script, 'set ' . shortname . '&') + " cannot change 'termencoding' in GTK + if name != 'termencoding' || !has('gui_gtk') + call add(script, 'set ' . name . '&') + call add(script, 'set ' . shortname . '&') + endif if name == 'verbosefile' call add(script, 'call delete("xxx")') endif