Mercurial > vim
changeset 25690:cb0868062915 v8.2.3381
patch 8.2.3381: crash when using NULL list with sign functions
Commit: https://github.com/vim/vim/commit/5c56da4de8398566ef96122db44ec93e6c2d483a
Author: Bram Moolenaar <Bram@vim.org>
Date: Sat Aug 28 14:42:25 2021 +0200
patch 8.2.3381: crash when using NULL list with sign functions
Problem: Crash when using NULL list with sign functions.
Solution: Handle a NULL list like an empty list. (issue https://github.com/vim/vim/issues/8260)
| author | Bram Moolenaar <Bram@vim.org> |
|---|---|
| date | Sat, 28 Aug 2021 14:45:03 +0200 |
| parents | aa8b03b01457 |
| children | 1c6f93ee1ed5 |
| files | src/globals.h src/testdir/test_signs.vim src/version.c |
| diffstat | 3 files changed, 10 insertions(+), 1 deletions(-) [+] |
line wrap: on
line diff
--- a/src/globals.h +++ b/src/globals.h @@ -1902,7 +1902,7 @@ EXTERN int channel_need_redraw INIT(= FA #endif #define FOR_ALL_LIST_ITEMS(l, li) \ - for ((li) = (l)->lv_first; (li) != NULL; (li) = (li)->li_next) + for ((li) = (l) == NULL ? NULL : (l)->lv_first; (li) != NULL; (li) = (li)->li_next) // While executing a regexp and set to OPTION_MAGIC_ON or OPTION_MAGIC_OFF this // overrules p_magic. Otherwise set to OPTION_MAGIC_NOT_SET.
--- a/src/testdir/test_signs.vim +++ b/src/testdir/test_signs.vim @@ -2012,4 +2012,11 @@ func Test_sign_funcs_multi() call delete("Xsign") endfunc +func Test_sign_null_list() + eval test_null_list()->sign_define() + eval test_null_list()->sign_placelist() + eval test_null_list()->sign_undefine() + eval test_null_list()->sign_unplacelist() +endfunc + " vim: shiftwidth=2 sts=2 expandtab