Mercurial > vim
changeset 22864:b825d8ec9a76 v8.2.1979
patch 8.2.1979: "term_opencmd" option of term_start() is truncated
Commit: https://github.com/vim/vim/commit/47c5ea44b975adca00eaacecee5c4108996178d9
Author: Bram Moolenaar <Bram@vim.org>
Date: Thu Nov 12 15:12:15 2020 +0100
patch 8.2.1979: "term_opencmd" option of term_start() is truncated
Problem: "term_opencmd" option of term_start() is truncated. (Sergey
Vlasov)
Solution: Allocate the buffer to hold the command. (closes #7284)
author | Bram Moolenaar <Bram@vim.org> |
---|---|
date | Thu, 12 Nov 2020 15:15:04 +0100 |
parents | 77566fd830f5 |
children | c026019f112a |
files | src/terminal.c src/testdir/test_terminal.vim src/version.c |
diffstat | 3 files changed, 18 insertions(+), 10 deletions(-) [+] |
line wrap: on
line diff
--- a/src/terminal.c +++ b/src/terminal.c @@ -3450,15 +3450,19 @@ term_after_channel_closed(term_T *term) if (term->tl_finish == TL_FINISH_OPEN && term->tl_buffer->b_nwindows == 0) { - char buf[50]; - - // TODO: use term_opencmd - ch_log(NULL, "terminal job finished, opening window"); - vim_snprintf(buf, sizeof(buf), - term->tl_opencmd == NULL - ? "botright sbuf %d" - : (char *)term->tl_opencmd, fnum); - do_cmdline_cmd((char_u *)buf); + char *cmd = term->tl_opencmd == NULL + ? "botright sbuf %d" + : (char *)term->tl_opencmd; + size_t len = strlen(cmd) + 50; + char *buf = alloc(len); + + if (buf != NULL) + { + ch_log(NULL, "terminal job finished, opening window"); + vim_snprintf(buf, len, cmd, fnum); + do_cmdline_cmd((char_u *)buf); + vim_free(buf); + } } else ch_log(NULL, "terminal job finished");
--- a/src/testdir/test_terminal.vim +++ b/src/testdir/test_terminal.vim @@ -567,10 +567,12 @@ func Test_terminal_finish_open_close() call assert_fails("call term_start(cmd, {'term_opencmd': 'split %d and %s'})", 'E475:') call assert_fails("call term_start(cmd, {'term_opencmd': 'split % and %d'})", 'E475:') - call term_start(cmd, {'term_finish': 'open', 'term_opencmd': '4split | buffer %d'}) + call term_start(cmd, {'term_finish': 'open', 'term_opencmd': '4split | buffer %d | let g:result = "opened the buffer in a window"'}) close! call WaitForAssert({-> assert_equal(2, winnr('$'))}, waittime) call assert_equal(4, winheight(0)) + call assert_equal('opened the buffer in a window', g:result) + unlet g:result bwipe endfunc