Mercurial > vim
changeset 30096:aa7109fe5bee v9.0.0384
patch 9.0.0384: Covertity still complains about using return value of getc()
Commit: https://github.com/vim/vim/commit/c7d2ff2ca03f1f36544a92cb93300eae06bcd0c0
Author: Bram Moolenaar <Bram@vim.org>
Date: Mon Sep 5 11:04:14 2022 +0100
patch 9.0.0384: Covertity still complains about using return value of getc()
Problem: Covertity still complains about using return value of getc().
Solution: Check for EOF.
| author | Bram Moolenaar <Bram@vim.org> |
|---|---|
| date | Mon, 05 Sep 2022 12:15:04 +0200 |
| parents | b5d880b3529e |
| children | 6a519b687eb4 |
| files | src/spellfile.c src/version.c |
| diffstat | 2 files changed, 5 insertions(+), 3 deletions(-) [+] |
line wrap: on
line diff
--- a/src/spellfile.c +++ b/src/spellfile.c @@ -846,7 +846,7 @@ read_region_section(FILE *fd, slang_T *l if (len > MAXREGIONS * 2) return SP_FORMERROR; for (i = 0; i < len; ++i) - lp->sl_regions[i] = c = getc(fd); // <regionname> + lp->sl_regions[i] = (c = getc(fd)) == EOF ? 0 : c; // <regionname> lp->sl_regions[len] = NUL; return c == EOF ? SP_TRUNCERROR : 0; } @@ -927,7 +927,7 @@ read_prefcond_section(FILE *fd, slang_T buf[0] = '^'; // always match at one position only p = buf + 1; while (n-- > 0) - *p++ = c = getc(fd); // <condstr> + *p++ = (c = getc(fd)) == EOF ? 0 : c; // <condstr> if (c == EOF) break; *p = NUL; @@ -1067,7 +1067,7 @@ read_sal_section(FILE *fd, slang_T *slan // store the char we got while checking for end of sm_lead *p++ = c; for (++i; i < ccnt; ++i) - *p++ = c = getc(fd); // <salfrom> + *p++ = (c = getc(fd)) == EOF ? 0 : c; // <salfrom> *p++ = NUL; // <saltolen> <salto>