Mercurial > vim
changeset 19693:9fbeb3bdf49e v8.2.0403
patch 8.2.0403: when 'buftype' is "nofile" there is no overwrite check
Commit: https://github.com/vim/vim/commit/a3a9c8ef697bbf6f640cde99710b6f534f29f77d
Author: Bram Moolenaar <Bram@vim.org>
Date: Thu Mar 19 12:38:34 2020 +0100
patch 8.2.0403: when 'buftype' is "nofile" there is no overwrite check
Problem: When 'buftype' is "nofile" there is no overwrite check.
Solution: Also check for existing file when 'buftype' is set.
(closes #5807)
author | Bram Moolenaar <Bram@vim.org> |
---|---|
date | Thu, 19 Mar 2020 12:45:04 +0100 |
parents | 95a9cf2b8a40 |
children | 196dcd448100 |
files | src/ex_cmds.c src/testdir/test_options.vim src/version.c |
diffstat | 3 files changed, 13 insertions(+), 6 deletions(-) [+] |
line wrap: on
line diff
--- a/src/ex_cmds.c +++ b/src/ex_cmds.c @@ -2074,8 +2074,8 @@ check_overwrite( int other) // writing under other name { /* - * write to other file or b_flags set or not writing the whole file: - * overwriting only allowed with '!' + * Write to another file or b_flags set or not writing the whole file: + * overwriting only allowed with '!'. */ if ( (other || (buf->b_flags & BF_NOTEDITED) @@ -2083,9 +2083,6 @@ check_overwrite( && vim_strchr(p_cpo, CPO_OVERNEW) == NULL) || (buf->b_flags & BF_READERR)) && !p_wa -#ifdef FEAT_QUICKFIX - && !bt_nofilename(buf) -#endif && vim_fexists(ffname)) { if (!eap->forceit && !eap->append)
--- a/src/testdir/test_options.vim +++ b/src/testdir/test_options.vim @@ -656,7 +656,15 @@ func Test_buftype() call setline(1, ['L1']) set buftype=nowrite call assert_fails('write', 'E382:') - close! + + for val in ['', 'nofile', 'nowrite', 'acwrite', 'quickfix', 'help', 'terminal', 'prompt', 'popup'] + exe 'set buftype=' .. val + call writefile(['something'], 'XBuftype') + call assert_fails('write XBuftype', 'E13:', 'with buftype=' .. val) + endfor + + call delete('XBuftype') + bwipe! endfunc " Test for the 'shellquote' option