changeset 10910:8bff367672a4 v8.0.0344

patch 8.0.0344: unlet command leaks memory commit https://github.com/vim/vim/commit/49439c4cdf7d2822255f292adda4226656fe144d Author: Bram Moolenaar <Bram@vim.org> Date: Mon Feb 20 23:07:05 2017 +0100 patch 8.0.0344: unlet command leaks memory Problem: Unlet command leaks memory. (Nikolai Pavlov) Solution: Free the memory on error. (closes https://github.com/vim/vim/issues/1497)
author Christian Brabandt <cb@256bit.org>
date Mon, 20 Feb 2017 23:15:04 +0100
parents e155b0b3d532
children 09f200404633
files src/eval.c src/testdir/test_unlet.vim src/version.c
diffstat 3 files changed, 9 insertions(+), 0 deletions(-) [+]
line wrap: on
line diff
--- a/src/eval.c
+++ b/src/eval.c
@@ -2079,7 +2079,10 @@ get_lval(
 	    }
 	    /* existing variable, need to check if it can be changed */
 	    else if (var_check_ro(lp->ll_di->di_flags, name, FALSE))
+	    {
+		clear_tv(&var1);
 		return NULL;
+	    }
 
 	    if (len == -1)
 		clear_tv(&var1);
--- a/src/testdir/test_unlet.vim
+++ b/src/testdir/test_unlet.vim
@@ -17,3 +17,7 @@ func Test_not_existing()
   unlet! does_not_exist
   call assert_fails('unlet does_not_exist', 'E108:')
 endfunc
+
+func Test_unlet_fails()
+  call assert_fails('unlet v:["count"]', 'E46:')
+endfunc
--- a/src/version.c
+++ b/src/version.c
@@ -765,6 +765,8 @@ static char *(features[]) =
 static int included_patches[] =
 {   /* Add new patch number below this line */
 /**/
+    344,
+/**/
     343,
 /**/
     342,