Mercurial > vim
changeset 12363:85fef6805d73 v8.0.1061
patch 8.0.1061: Coverity: no check for NULL command
commit https://github.com/vim/vim/commit/6756c7037f07e1fb54e1b9d8e92567ac388617c4
Author: Bram Moolenaar <Bram@vim.org>
Date: Tue Sep 5 23:01:12 2017 +0200
patch 8.0.1061: Coverity: no check for NULL command
Problem: Coverity: no check for NULL command.
Solution: Check for NULL list item.
author | Christian Brabandt <cb@256bit.org> |
---|---|
date | Tue, 05 Sep 2017 23:15:04 +0200 |
parents | 4ab904b8b1ee |
children | 252f7d25c88f |
files | src/terminal.c src/version.c |
diffstat | 2 files changed, 10 insertions(+), 4 deletions(-) [+] |
line wrap: on
line diff
--- a/src/terminal.c +++ b/src/terminal.c @@ -38,7 +38,9 @@ * in tl_scrollback are no longer used. * * TODO: - * - ":term NONE" does not work in MS-Windows. + * - ":term NONE" does not work on MS-Windows. + * https://github.com/vim/vim/pull/2056 + * - Redirecting output does not work on MS-Windows. * - implement term_setsize() * - add test for giving error for invalid 'termsize' value. * - support minimal size when 'termsize' is "rows*cols". @@ -56,6 +58,8 @@ * - In the GUI use a terminal emulator for :!cmd. * - Copy text in the vterm to the Vim buffer once in a while, so that * completion works. + * - add an optional limit for the scrollback size. When reaching it remove + * 10% at the start. */ #include "vim.h" @@ -366,10 +370,10 @@ term_start(typval_T *argvar, jobopt_T *o } else if (argvar->v_type != VAR_LIST || argvar->vval.v_list == NULL - || argvar->vval.v_list->lv_len < 1) + || argvar->vval.v_list->lv_len < 1 + || (cmd = get_tv_string_chk( + &argvar->vval.v_list->lv_first->li_tv)) == NULL) cmd = (char_u*)""; - else - cmd = get_tv_string_chk(&argvar->vval.v_list->lv_first->li_tv); len = STRLEN(cmd) + 10; p = alloc((int)len);