Mercurial > vim
changeset 22852:84e4dedfa388 v8.2.1973
patch 8.2.1973: finding a patch number can be a bit slow
Commit: https://github.com/vim/vim/commit/232f4612e2b0a6a205ae385740078f6b8af05e75
Author: Bram Moolenaar <Bram@vim.org>
Date: Tue Nov 10 20:54:29 2020 +0100
patch 8.2.1973: finding a patch number can be a bit slow
Problem: Finding a patch number can be a bit slow.
Solution: Use binary search. (closes https://github.com/vim/vim/issues/7279)
| author | Bram Moolenaar <Bram@vim.org> |
|---|---|
| date | Tue, 10 Nov 2020 21:00:04 +0100 |
| parents | 86edcfa72e2a |
| children | ea83a529434d |
| files | src/version.c |
| diffstat | 1 files changed, 16 insertions(+), 6 deletions(-) [+] |
line wrap: on
line diff
--- a/src/version.c +++ b/src/version.c @@ -751,6 +751,8 @@ static char *(features[]) = static int included_patches[] = { /* Add new patch number below this line */ /**/ + 1973, +/**/ 1972, /**/ 1971, @@ -4725,11 +4727,21 @@ highest_patch(void) int has_patch(int n) { - int i; + int h, m, l; - for (i = 0; included_patches[i] != 0; ++i) - if (included_patches[i] == n) + // Perform a binary search. + l = 0; + h = (int)(sizeof(included_patches) / sizeof(included_patches[0])) - 1; + while (l < h) + { + m = (l + h) / 2; + if (included_patches[m] == n) return TRUE; + if (included_patches[m] < n) + h = m; + else + l = m + 1; + } return FALSE; } #endif @@ -4941,9 +4953,7 @@ list_version(void) { msg_puts(_("\nIncluded patches: ")); first = -1; - // find last one - for (i = 0; included_patches[i] != 0; ++i) - ; + i = (int)(sizeof(included_patches) / sizeof(included_patches[0])) - 1; while (--i >= 0) { if (first < 0)