Mercurial > vim
changeset 30071:6a8c2ff5b2ef v9.0.0373
patch 9.0.0373: Coverity warns for NULL check and unused return value
Commit: https://github.com/vim/vim/commit/a5348f241bbbb6d5db863d666fa9ca72fc95037a
Author: Bram Moolenaar <Bram@vim.org>
Date: Sun Sep 4 11:42:22 2022 +0100
patch 9.0.0373: Coverity warns for NULL check and unused return value
Problem: Coverity warns for NULL check and unused return value.
Solution: Remove the NULL check, it was already checked earlier. Add (void)
to ignore the return value.
| author | Bram Moolenaar <Bram@vim.org> |
|---|---|
| date | Sun, 04 Sep 2022 12:45:05 +0200 |
| parents | 1165ce8ec863 |
| children | c290472b786b |
| files | src/ex_eval.c src/version.c src/vim9execute.c |
| diffstat | 3 files changed, 5 insertions(+), 4 deletions(-) [+] |
line wrap: on
line diff
--- a/src/ex_eval.c +++ b/src/ex_eval.c @@ -925,7 +925,7 @@ cmd_is_name_only(char_u *arg) } else if (*p == '$') ++p; - get_name_len(&p, &alias, FALSE, FALSE); + (void)get_name_len(&p, &alias, FALSE, FALSE); } name_only = ends_excmd2(arg, skipwhite(p)); vim_free(alias);
--- a/src/version.c +++ b/src/version.c @@ -708,6 +708,8 @@ static char *(features[]) = static int included_patches[] = { /* Add new patch number below this line */ /**/ + 373, +/**/ 372, /**/ 371,
--- a/src/vim9execute.c +++ b/src/vim9execute.c @@ -862,7 +862,7 @@ add_defer_func(int var_idx, int argcount if (defer_tv->v_type != VAR_LIST) { - // first one, allocate the list + // first time, allocate the list if (rettv_list_alloc(defer_tv) == FAIL) return FAIL; } @@ -874,8 +874,7 @@ add_defer_func(int var_idx, int argcount listval.v_type = VAR_LIST; listval.vval.v_list = l; listval.v_lock = 0; - if (list_insert_tv(defer_l, &listval, - defer_l == NULL ? NULL : defer_l->lv_first) == FAIL) + if (list_insert_tv(defer_l, &listval, defer_l->lv_first) == FAIL) { vim_free(l); return FAIL;