Mercurial > vim
changeset 35139:617f9087f97c v9.1.0399
patch 9.1.0399: block_editing errors out when using del
Commit: https://github.com/vim/vim/commit/d5c8c0920e1eee9ff7a9fa5168d8e85c01670630
Author: Christian Brabandt <cb@256bit.org>
Date: Wed May 8 22:17:19 2024 +0200
patch 9.1.0399: block_editing errors out when using del
Problem: block_editing errors out when using del
(@Jamarley)
Solution: Change ins_len from size_t to int and
properly check that it doesn't become negative
There is a check in os.c that verifies that `ins_len` does not become
negative:
```
if (pre_textlen >= 0 && (ins_len = len - pre_textlen - offset) > 0)
```
However this only works, if ins_len can actually become negative and
unfortunately, ins_len has been declared as `size_t` so instead of
becoming negative it will wrap around and be very large.
So let's define it as integer, after which the condition above
properly catches this condition.
fixes: #14734
closes: #14735
Signed-off-by: Christian Brabandt <cb@256bit.org>
| author | Christian Brabandt <cb@256bit.org> |
|---|---|
| date | Wed, 08 May 2024 22:30:03 +0200 |
| parents | 98327050d01d |
| children | 9ba95f736abb |
| files | src/ops.c src/testdir/test_visual.vim src/version.c |
| diffstat | 3 files changed, 11 insertions(+), 1 deletions(-) [+] |
line wrap: on
line diff
--- a/src/ops.c +++ b/src/ops.c @@ -1608,7 +1608,7 @@ op_insert(oparg_T *oap, long count1) if (oap->block_mode) { - size_t ins_len; + int ins_len; char_u *firstline, *ins_text; struct block_def bd2; int did_indent = FALSE;
--- a/src/testdir/test_visual.vim +++ b/src/testdir/test_visual.vim @@ -2031,4 +2031,12 @@ func Test_getregion_maxcol() bwipe! endfunc +func Test_visual_block_cursor_delete() + new + call setline(1, 'ab') + exe ":norm! $\<c-v>hI\<Del>\<ESC>" + call assert_equal(['b'], getline(1, 1)) + bwipe! +endfunc + " vim: shiftwidth=2 sts=2 expandtab