changeset 29253:5dd393285464 v8.2.5145

patch 8.2.5145: exit test causes spurious valgrind reports Commit: https://github.com/vim/vim/commit/cf801d4b95180ddaee1bf633ef482232625dd80b Author: Bram Moolenaar <Bram@vim.org> Date: Tue Jun 21 18:34:42 2022 +0100 patch 8.2.5145: exit test causes spurious valgrind reports Problem: Exit test causes spurious valgrind reports. Solution: Skip test. Add CheckNotValgrind.
author Bram Moolenaar <Bram@vim.org>
date Tue, 21 Jun 2022 19:45:03 +0200
parents 49805cb64d1d
children acb7f19c9d07
files src/testdir/check.vim src/testdir/test_channel.vim src/testdir/test_exit.vim src/version.c
diffstat 4 files changed, 12 insertions(+), 3 deletions(-) [+]
line wrap: on
line diff
--- a/src/testdir/check.vim
+++ b/src/testdir/check.vim
@@ -217,6 +217,14 @@ func CheckNotAsan()
   endif
 endfunc
 
+" Command to check for not running under valgrind
+command CheckNotValgrind call CheckNotValgrind()
+func CheckNotValgrind()
+  if RunningWithValgrind()
+    throw 'Skipped: does not work well with valgrind'
+  endif
+endfunc
+
 " Command to check for X11 based GUI
 command CheckX11BasedGui call CheckX11BasedGui()
 func CheckX11BasedGui()
--- a/src/testdir/test_channel.vim
+++ b/src/testdir/test_channel.vim
@@ -1793,9 +1793,7 @@ endfunc
 
 func Test_job_stop_immediately()
   " With valgrind this causes spurious leak reports
-  if RunningWithValgrind()
-    return
-  endif
+  CheckNotValgrind
 
   let g:job = job_start([s:python, '-c', 'import time;time.sleep(10)'])
   try
--- a/src/testdir/test_exit.vim
+++ b/src/testdir/test_exit.vim
@@ -115,6 +115,7 @@ func Test_exit_error_reading_input()
   CheckNotMSWindows
   " The early exit causes memory not to be freed somehow
   CheckNotAsan
+  CheckNotValgrind
 
   call writefile([":au VimLeave * call writefile(['l = ' .. v:exiting], 'Xtestout')", ":tabnew", "q:"], 'Xscript', 'b')
 
--- a/src/version.c
+++ b/src/version.c
@@ -735,6 +735,8 @@ static char *(features[]) =
 static int included_patches[] =
 {   /* Add new patch number below this line */
 /**/
+    5145,
+/**/
     5144,
 /**/
     5143,