Mercurial > vim

changeset 35545:59ca6cfe3d57 v9.1.0531

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
patch 9.1.0531: resource leak in mch_get_random() Commit: https://github.com/vim/vim/commit/93a3d2b905f1012aa0eac8db36b31ce01c3571f3 Author: Christian Brabandt <cb@256bit.org> Date: Fri Jul 5 09:54:30 2024 +0200 patch 9.1.0531: resource leak in mch_get_random() Problem: resource leak in mch_get_random() (after v9.1.0518) Solution: close file descriptor after reading successfully from /dev/urandom Signed-off-by: Christian Brabandt <cb@256bit.org>
author Christian Brabandt <cb@256bit.org>
date Fri, 05 Jul 2024 10:00:09 +0200
parents 993a2cf6d27c
children 8bde33d3d85f
files src/os_unix.c src/version.c
diffstat 2 files changed, 5 insertions(+), 0 deletions(-) [+]
line wrap: on
line diff
--- a/src/os_unix.c
+++ b/src/os_unix.c
@@ -7740,7 +7740,10 @@ mch_get_random(char_u *buf, int len)
     if (fd == -1)
 	dev_urandom_state = FAIL;
     else if (read(fd, buf, len) == len)
+    {
 	dev_urandom_state = OK;
+	close(fd);
+    }
     else
     {
 	dev_urandom_state = FAIL;
--- a/src/version.c
+++ b/src/version.c
@@ -705,6 +705,8 @@ static char *(features[]) =
 static int included_patches[] =
 {   /* Add new patch number below this line */
 /**/
+    531,
+/**/
     530,
 /**/
     529,