changeset 11079:50459aeb4773 v8.0.0428

patch 8.0.0428: git and hg see new files after running tests commit https://github.com/vim/vim/commit/65408f7dfbd4bb50d740a8b8f2171080571223f2 Author: Bram Moolenaar <Bram@vim.org> Date: Tue Mar 7 21:31:27 2017 +0100 patch 8.0.0428: git and hg see new files after running tests Problem: Git and hg see new files after running tests. (Manuel Ortega) Solution: Add the generated file to .hgignore (or .gitignore). Delete the resulting verbose file. (Christian Brabandt) Improve dependency on opt_test.vim. Reset the 'more' option.
author Christian Brabandt <cb@256bit.org>
date Tue, 07 Mar 2017 21:45:04 +0100
parents b3f6526848a9
children 4348ed867eb1
files .gitignore Filelist src/Makefile src/gen_opt_test.vim src/testdir/Make_all.mak src/testdir/Make_dos.mak src/testdir/Make_ming.mak src/testdir/Makefile src/testdir/gen_opt_test.vim src/version.c
diffstat 10 files changed, 221 insertions(+), 202 deletions(-) [+]
line wrap: on
line diff
--- a/.gitignore
+++ b/.gitignore
@@ -78,6 +78,7 @@ src/testdir/test.log
 src/testdir/dostmp/*
 src/testdir/messages
 src/testdir/viminfo
+src/testdir/opt_test.vim
 src/memfile_test
 src/json_test
 src/message_test
--- a/Filelist
+++ b/Filelist
@@ -97,7 +97,7 @@ SRC_ALL =	\
 		src/tee/tee.c \
 		src/xxd/xxd.c \
 		src/main.aap \
-		src/gen_opt_test.vim \
+		src/testdir/gen_opt_test.vim \
 		src/testdir/main.aap \
 		src/testdir/README.txt \
 		src/testdir/Make_all.mak \
--- a/src/Makefile
+++ b/src/Makefile
@@ -2025,7 +2025,6 @@ test check: scripttests unittests
 #
 scripttests:
 	$(MAKE) -f Makefile $(VIMTARGET)
-	$(MAKE) -f Makefile testdir/opt_test.vim
 	if test -n "$(MAKEMO)" -a -f $(PODIR)/Makefile; then \
 		cd $(PODIR); $(MAKE) -f Makefile check VIM=../$(VIMTARGET); \
 	fi
@@ -2034,9 +2033,6 @@ scripttests:
 	fi
 	cd testdir; $(MAKE) -f Makefile $(GUI_TESTTARGET) VIMPROG=../$(VIMTARGET) $(GUI_TESTARG) SCRIPTSOURCE=../$(SCRIPTSOURCE)
 
-testdir/opt_test.vim: option.c gen_opt_test.vim
-	./$(VIMTARGET) -u gen_opt_test.vim --noplugin --not-a-term
-
 # Run the tests with the GUI.  Assumes vim/gvim was already built
 testgui:
 	cd testdir; $(MAKE) -f Makefile $(GUI_TESTTARGET) VIMPROG=../$(VIMTARGET) GUI_FLAG=-g $(GUI_TESTARG) SCRIPTSOURCE=../$(SCRIPTSOURCE)
deleted file mode 100644
--- a/src/gen_opt_test.vim
+++ /dev/null
@@ -1,196 +0,0 @@
-" Script to generate testdir/opt_test.vim from option.c
-
-set cpo=&vim
-
-" Only do this when build with the +eval feature.
-if 1
-
-set nomore
-
-let script = [
-      \ 'let save_columns = &columns',
-      \ 'let save_lines = &lines',
-      \ 'let save_term = &term',
-      \ ]
-
-edit option.c
-/#define p_term
-let end = line('.')
-
-" Two lists with values: values that work and values that fail.
-" When not listed, "othernum" or "otherstring" is used.
-let test_values = {
-      \ 'cmdheight': [[1, 2, 10], [-1, 0]],
-      \ 'cmdwinheight': [[1, 2, 10], [-1, 0]],
-      \ 'columns': [[12, 80], [-1, 0, 10]],
-      \ 'conceallevel': [[0, 1, 2, 3], [-1, 4, 99]],
-      \ 'foldcolumn': [[0, 1, 4, 12], [-1, 13, 999]],
-      \ 'helpheight': [[0, 10, 100], [-1]],
-      \ 'history': [[0, 1, 100], [-1, 10001]],
-      \ 'iminsert': [[0, 1], [-1, 3, 999]],
-      \ 'imsearch': [[-1, 0, 1], [-2, 3, 999]],
-      \ 'lines': [[2, 24], [-1, 0, 1]],
-      \ 'numberwidth': [[1, 4, 8, 10], [-1, 0, 11]],
-      \ 'regexpengine': [[0, 1, 2], [-1, 3, 999]],
-      \ 'report': [[0, 1, 2, 9999], [-1]],
-      \ 'scroll': [[0, 1, 2, 20], [-1]],
-      \ 'scrolljump': [[-50, -1, 0, 1, 2, 20], [999]],
-      \ 'scrolloff': [[0, 1, 2, 20], [-1]],
-      \ 'shiftwidth': [[0, 1, 8, 999], [-1]],
-      \ 'sidescroll': [[0, 1, 8, 999], [-1]],
-      \ 'sidescrolloff': [[0, 1, 8, 999], [-1]],
-      \ 'tabstop': [[1, 4, 8, 12], [-1, 0]],
-      \ 'textwidth': [[0, 1, 8, 99], [-1]],
-      \ 'timeoutlen': [[0, 8, 99999], [-1]],
-      \ 'titlelen': [[0, 1, 8, 9999], [-1]],
-      \ 'updatecount': [[0, 1, 8, 9999], [-1]],
-      \ 'updatetime': [[0, 1, 8, 9999], [-1]],
-      \ 'verbose': [[-1, 0, 1, 8, 9999], []],
-      \ 'wildcharm': [[-1, 0, 100], []],
-      \ 'winheight': [[1, 10, 999], [-1, 0]],
-      \ 'winminheight': [[0, 1], [-1]],
-      \ 'winminwidth': [[0, 1, 10], [-1]],
-      \ 'winwidth': [[1, 10, 999], [-1, 0]],
-      \
-      \ 'ambiwidth': [['', 'single'], ['xxx']],
-      \ 'background': [['', 'light', 'dark'], ['xxx']],
-      \ 'backspace': [[0, 2, '', 'eol', 'eol,start'], ['xxx']],
-      \ 'backupcopy': [['yes', 'auto'], ['', 'xxx', 'yes,no']],
-      \ 'backupext': [['xxx'], ['']],
-      \ 'belloff': [['', 'all', 'copy,error'], ['xxx']],
-      \ 'breakindentopt': [['', 'min:3', 'sbr'], ['xxx', 'min', 'min:x']],
-      \ 'browsedir': [['', 'last', '/tmp/'], ['xxx']],
-      \ 'bufhidden': [['', 'hide', 'wipe'], ['xxx', 'hide,wipe']],
-      \ 'buftype': [['', 'help', 'nofile'], ['xxx', 'help,nofile']],
-      \ 'casemap': [['', 'internal'], ['xxx']],
-      \ 'cedit': [['', '\<Esc>'], ['xxx', 'f']],
-      \ 'clipboard': [['', 'unnamed', 'autoselect,unnamed'], ['xxx']],
-      \ 'colorcolumn': [['', '8', '+2'], ['xxx']],
-      \ 'comments': [['', 'b:#'], ['xxx']],
-      \ 'commentstring': [['', '/*%s*/'], ['xxx']],
-      \ 'complete': [['', 'w,b'], ['xxx']],
-      \ 'concealcursor': [['', 'n', 'nvic'], ['xxx']],
-      \ 'completeopt': [['', 'menu', 'menu,longest'], ['xxx', 'menu,,,longest,']],
-      \ 'cryptmethod': [['', 'zip'], ['xxx']],
-      \ 'cscopequickfix': [['', 's-', 's-,c+,e0'], ['xxx', 's,g,d']],
-      \ 'debug': [['', 'msg', 'msg', 'beep'], ['xxx']],
-      \ 'diffopt': [['', 'filler', 'icase,iwhite'], ['xxx']],
-      \ 'display': [['', 'lastline', 'lastline,uhex'], ['xxx']],
-      \ 'eadirection': [['', 'both', 'ver'], ['xxx', 'ver,hor']],
-      \ 'encoding': [['latin1'], ['xxx', '']],
-      \ 'eventignore': [['', 'WinEnter', 'WinLeave,winenter'], ['xxx']],
-      \ 'fileencoding': [['', 'latin1', 'xxx'], []],
-      \ 'fileformat': [['', 'dos', 'unix'], ['xxx']],
-      \ 'fileformats': [['', 'dos', 'dos,unix'], ['xxx']],
-      \ 'fillchars': [['', 'vert:x'], ['xxx']],
-      \ 'foldclose': [['', 'all'], ['xxx']],
-      \ 'foldmethod': [['manual', 'indent'], ['', 'xxx', 'expr,diff']],
-      \ 'foldopen': [['', 'all', 'hor,jump'], ['xxx']],
-      \ 'foldmarker': [['((,))'], ['', 'xxx']],
-      \ 'formatoptions': [['', 'vt', 'v,t'], ['xxx']],
-      \ 'guicursor': [['', 'n:block-Cursor'], ['xxx']],
-      \ 'helplang': [['', 'de', 'de,it'], ['xxx']],
-      \ 'highlight': [['', 'e:Error'], ['xxx']],
-      \ 'isfname': [['', '@', '@,48-52'], ['xxx', '@48']],
-      \ 'isident': [['', '@', '@,48-52'], ['xxx', '@48']],
-      \ 'iskeyword': [['', '@', '@,48-52'], ['xxx', '@48']],
-      \ 'isprint': [['', '@', '@,48-52'], ['xxx', '@48']],
-      \ 'keymap': [['', 'accents'], ['xxx']],
-      \ 'keymodel': [['', 'startsel', 'startsel,stopsel'], ['xxx']],
-      \ 'langmap': [['', 'xX', 'aA,bB'], ['xxx']],
-      \ 'listchars': [['', 'eol:x', 'eol:x,space:y'], ['xxx']],
-      \ 'matchpairs': [['', '(:)', '(:),<:>'], ['xxx']],
-      \ 'mkspellmem': [['10000,100,12'], ['', 'xxx']],
-      \ 'mouse': [['', 'a', 'nvi'], ['xxx', 'n,v,i']],
-      \ 'mousemodel': [['', 'popup'], ['xxx']],
-      \ 'mouseshape': [['', 'n:arrow'], ['xxx']],
-      \ 'nrformats': [['', 'alpha', 'alpha,hex,bin'], ['xxx']],
-      \ 'printmbfont': [['', 'r:some', 'b:Bold,c:yes'], ['xxx']],
-      \ 'printoptions': [['', 'header:0', 'left:10pc,top:5pc'], ['xxx']],
-      \ 'scrollopt': [['', 'ver', 'ver,hor'], ['xxx']],
-      \ 'selection': [['old', 'inclusive'], ['', 'xxx']],
-      \ 'selectmode': [['', 'mouse', 'key,cmd'], ['xxx']],
-      \ 'sessionoptions': [['', 'blank', 'help,options,slash'], ['xxx']],
-      \ 'signcolumn': [['', 'auto', 'no'], ['xxx', 'no,yes']],
-      \ 'spellfile': [['', 'file.en.add'], ['xxx', '/tmp/file']],
-      \ 'spellsuggest': [['', 'best', 'double,33'], ['xxx']],
-      \ 'switchbuf': [['', 'useopen', 'split,newtab'], ['xxx']],
-      \ 'tagcase': [['smart', 'match'], ['', 'xxx', 'smart,match']],
-      \ 'term': [['ansi'], ['', 'gui']],
-      \ 'toolbar': [['', 'icons', 'text'], ['xxx']],
-      \ 'toolbariconsize': [['', 'tiny', 'huge'], ['xxx']],
-      \ 'ttymouse': [['', 'xterm'], ['xxx']],
-      \ 'ttytype': [['ansi'], ['', 'gui']],
-      \ 'viewoptions': [['', 'cursor', 'unix,slash'], ['xxx']],
-      \ 'viminfo': [['', '''50', '"30'], ['xxx']],
-      \ 'virtualedit': [['', 'all', 'all,block'], ['xxx']],
-      \ 'whichwrap': [['', 'b,s', 'bs'], ['xxx']],
-      \ 'wildmode': [['', 'full', 'list:full', 'full,longest'], ['xxx']],
-      \ 'wildoptions': [['', 'tagfile'], ['xxx']],
-      \ 'winaltkeys': [['menu', 'no'], ['', 'xxx']],
-      \
-      \ 'luadll': [[], []],
-      \ 'perldll': [[], []],
-      \ 'pythondll': [[], []],
-      \ 'pythonthreedll': [[], []],
-      \ 'pyxversion': [[], []],
-      \ 'rubydll': [[], []],
-      \ 'tcldll': [[], []],
-      \
-      \ 'othernum': [[-1, 0, 100], ['']],
-      \ 'otherstring': [['', 'xxx'], []],
-      \}
-
-1
-/struct vimoption options
-while 1
-  /{"
-  if line('.') > end
-    break
-  endif
-  let line = getline('.')
-  let name = substitute(line, '.*{"\([^"]*\)".*', '\1', '')
-  let shortname = substitute(line, '.*"\([^"]*\)".*', '\1', '')
-
-  if has_key(test_values, name)
-    let a = test_values[name]
-  elseif line =~ 'P_NUM'
-    let a = test_values['othernum']
-  else
-    let a = test_values['otherstring']
-  endif
-  if len(a[0]) > 0 || len(a[1]) > 0
-    if line =~ 'P_BOOL'
-      call add(script, 'set ' . name)
-      call add(script, 'set ' . shortname)
-      call add(script, 'set no' . name)
-      call add(script, 'set no' . shortname)
-    else
-      for val in a[0]
-	call add(script, 'set ' . name . '=' . val)
-	call add(script, 'set ' . shortname . '=' . val)
-      endfor
-
-      " setting an option can only fail when it's implemented.
-      call add(script, "if exists('+" . name . "')")
-      for val in a[1]
-	call add(script, "call assert_fails('set " . name . "=" . val . "')")
-	call add(script, "call assert_fails('set " . shortname . "=" . val . "')")
-      endfor
-      call add(script, "endif")
-    endif
-
-    call add(script, 'set ' . name . '&')
-    call add(script, 'set ' . shortname . '&')
-  endif
-endwhile
-
-call add(script, 'let &term = save_term')
-call add(script, 'let &columns = save_columns')
-call add(script, 'let &lines = save_lines')
-
-call writefile(script, 'testdir/opt_test.vim')
-
-endif
-
-qa!
--- a/src/testdir/Make_all.mak
+++ b/src/testdir/Make_all.mak
@@ -221,3 +221,4 @@ test49.out: test49.vim
 
 test60.out: test60.vim
 
+test_options.res: opt_test.vim
--- a/src/testdir/Make_dos.mak
+++ b/src/testdir/Make_dos.mak
@@ -94,6 +94,7 @@ clean:
 	-if exist test.log del test.log
 	-if exist messages del messages
 	-if exist benchmark.out del benchmark.out
+	-if exist opt_test.vim del opt_test.vim
 
 nolog:
 	-if exist test.log del test.log
@@ -127,3 +128,6 @@ test_gui_init.res: test_gui_init.vim
 	@echo "$(VIMPROG)" > vimcmd
 	$(VIMPROG) -u NONE -U gui_init.vim $(NO_PLUGINS) -S runtest.vim $*.vim
 	@del vimcmd
+
+opt_test.vim: ../option.c gen_opt_test.vim
+	$(VIMPROG) -u gen_opt_test.vim --noplugin --not-a-term
--- a/src/testdir/Make_ming.mak
+++ b/src/testdir/Make_ming.mak
@@ -88,6 +88,7 @@ clean:
 	-@if exist viminfo $(DEL) viminfo
 	-@if exist test.log $(DEL) test.log
 	-@if exist messages $(DEL) messages
+	-@if exist opt_test.vim $(DEL) opt_test.vim
 
 .in.out:
 	-@if exist $*.ok $(CP) $*.ok test.ok
@@ -131,3 +132,5 @@ test_gui_init.res: test_gui_init.vim
 	$(VIMPROG) -u NONE -U gui_init.vim $(NO_PLUGINS) -S runtest.vim $<
 	@$(DEL) vimcmd
 
+opt_test.vim: ../option.c gen_opt_test.vim
+	$(VIMPROG) -u gen_opt_test.vim --noplugin --not-a-term
--- a/src/testdir/Makefile
+++ b/src/testdir/Makefile
@@ -55,7 +55,7 @@ RM_ON_START = tiny.vim small.vim mbyte.v
 RUN_VIM = VIMRUNTIME=$(SCRIPTSOURCE); export VIMRUNTIME; $(VALGRIND) $(VIMPROG) -f $(GUI_FLAG) -u unix.vim $(NO_INITS) -s dotest.in
 
 clean:
-	-rm -rf *.out *.failed *.res *.rej *.orig test.log messages $(RM_ON_RUN) $(RM_ON_START) valgrind.*
+	-rm -rf *.out *.failed *.res *.rej *.orig opt_test.vim test.log messages $(RM_ON_RUN) $(RM_ON_START) valgrind.*
 
 test1.out: test1.in
 	-rm -rf $*.failed $(RM_ON_RUN) $(RM_ON_START) wrongtermsize
@@ -140,3 +140,7 @@ test_gui_init.res: test_gui_init.vim
 	@echo "$(RUN_GVIMTEST_WITH_GVIMRC)" > vimcmd
 	$(RUN_VIMTEST) -u NONE -U gui_init.vim $(NO_PLUGINS) -S runtest.vim $<
 	@rm vimcmd
+
+opt_test.vim: ../option.c gen_opt_test.vim
+	$(VIMPROG) -u gen_opt_test.vim --noplugin --not-a-term
+
new file mode 100644
--- /dev/null
+++ b/src/testdir/gen_opt_test.vim
@@ -0,0 +1,204 @@
+" Script to generate testdir/opt_test.vim from option.c
+
+set cpo=&vim
+
+" Only do this when build with the +eval feature.
+if 1
+
+set nomore
+
+let script = [
+      \ 'let save_columns = &columns',
+      \ 'let save_lines = &lines',
+      \ 'let save_term = &term',
+      \ ]
+
+edit option.c
+/#define p_term
+let end = line('.')
+
+" Two lists with values: values that work and values that fail.
+" When not listed, "othernum" or "otherstring" is used.
+let test_values = {
+      \ 'cmdheight': [[1, 2, 10], [-1, 0]],
+      \ 'cmdwinheight': [[1, 2, 10], [-1, 0]],
+      \ 'columns': [[12, 80], [-1, 0, 10]],
+      \ 'conceallevel': [[0, 1, 2, 3], [-1, 4, 99]],
+      \ 'foldcolumn': [[0, 1, 4, 12], [-1, 13, 999]],
+      \ 'helpheight': [[0, 10, 100], [-1]],
+      \ 'history': [[0, 1, 100], [-1, 10001]],
+      \ 'iminsert': [[0, 1], [-1, 3, 999]],
+      \ 'imsearch': [[-1, 0, 1], [-2, 3, 999]],
+      \ 'lines': [[2, 24], [-1, 0, 1]],
+      \ 'numberwidth': [[1, 4, 8, 10], [-1, 0, 11]],
+      \ 'regexpengine': [[0, 1, 2], [-1, 3, 999]],
+      \ 'report': [[0, 1, 2, 9999], [-1]],
+      \ 'scroll': [[0, 1, 2, 20], [-1]],
+      \ 'scrolljump': [[-50, -1, 0, 1, 2, 20], [999]],
+      \ 'scrolloff': [[0, 1, 2, 20], [-1]],
+      \ 'shiftwidth': [[0, 1, 8, 999], [-1]],
+      \ 'sidescroll': [[0, 1, 8, 999], [-1]],
+      \ 'sidescrolloff': [[0, 1, 8, 999], [-1]],
+      \ 'tabstop': [[1, 4, 8, 12], [-1, 0]],
+      \ 'textwidth': [[0, 1, 8, 99], [-1]],
+      \ 'timeoutlen': [[0, 8, 99999], [-1]],
+      \ 'titlelen': [[0, 1, 8, 9999], [-1]],
+      \ 'updatecount': [[0, 1, 8, 9999], [-1]],
+      \ 'updatetime': [[0, 1, 8, 9999], [-1]],
+      \ 'verbose': [[-1, 0, 1, 8, 9999], []],
+      \ 'wildcharm': [[-1, 0, 100], []],
+      \ 'winheight': [[1, 10, 999], [-1, 0]],
+      \ 'winminheight': [[0, 1], [-1]],
+      \ 'winminwidth': [[0, 1, 10], [-1]],
+      \ 'winwidth': [[1, 10, 999], [-1, 0]],
+      \
+      \ 'ambiwidth': [['', 'single'], ['xxx']],
+      \ 'background': [['', 'light', 'dark'], ['xxx']],
+      \ 'backspace': [[0, 2, '', 'eol', 'eol,start'], ['xxx']],
+      \ 'backupcopy': [['yes', 'auto'], ['', 'xxx', 'yes,no']],
+      \ 'backupext': [['xxx'], ['']],
+      \ 'belloff': [['', 'all', 'copy,error'], ['xxx']],
+      \ 'breakindentopt': [['', 'min:3', 'sbr'], ['xxx', 'min', 'min:x']],
+      \ 'browsedir': [['', 'last', '/tmp/'], ['xxx']],
+      \ 'bufhidden': [['', 'hide', 'wipe'], ['xxx', 'hide,wipe']],
+      \ 'buftype': [['', 'help', 'nofile'], ['xxx', 'help,nofile']],
+      \ 'casemap': [['', 'internal'], ['xxx']],
+      \ 'cedit': [['', '\<Esc>'], ['xxx', 'f']],
+      \ 'clipboard': [['', 'unnamed', 'autoselect,unnamed'], ['xxx']],
+      \ 'colorcolumn': [['', '8', '+2'], ['xxx']],
+      \ 'comments': [['', 'b:#'], ['xxx']],
+      \ 'commentstring': [['', '/*%s*/'], ['xxx']],
+      \ 'complete': [['', 'w,b'], ['xxx']],
+      \ 'concealcursor': [['', 'n', 'nvic'], ['xxx']],
+      \ 'completeopt': [['', 'menu', 'menu,longest'], ['xxx', 'menu,,,longest,']],
+      \ 'cryptmethod': [['', 'zip'], ['xxx']],
+      \ 'cscopequickfix': [['', 's-', 's-,c+,e0'], ['xxx', 's,g,d']],
+      \ 'debug': [['', 'msg', 'msg', 'beep'], ['xxx']],
+      \ 'diffopt': [['', 'filler', 'icase,iwhite'], ['xxx']],
+      \ 'display': [['', 'lastline', 'lastline,uhex'], ['xxx']],
+      \ 'eadirection': [['', 'both', 'ver'], ['xxx', 'ver,hor']],
+      \ 'encoding': [['latin1'], ['xxx', '']],
+      \ 'eventignore': [['', 'WinEnter', 'WinLeave,winenter'], ['xxx']],
+      \ 'fileencoding': [['', 'latin1', 'xxx'], []],
+      \ 'fileformat': [['', 'dos', 'unix'], ['xxx']],
+      \ 'fileformats': [['', 'dos', 'dos,unix'], ['xxx']],
+      \ 'fillchars': [['', 'vert:x'], ['xxx']],
+      \ 'foldclose': [['', 'all'], ['xxx']],
+      \ 'foldmethod': [['manual', 'indent'], ['', 'xxx', 'expr,diff']],
+      \ 'foldopen': [['', 'all', 'hor,jump'], ['xxx']],
+      \ 'foldmarker': [['((,))'], ['', 'xxx']],
+      \ 'formatoptions': [['', 'vt', 'v,t'], ['xxx']],
+      \ 'guicursor': [['', 'n:block-Cursor'], ['xxx']],
+      \ 'helplang': [['', 'de', 'de,it'], ['xxx']],
+      \ 'highlight': [['', 'e:Error'], ['xxx']],
+      \ 'isfname': [['', '@', '@,48-52'], ['xxx', '@48']],
+      \ 'isident': [['', '@', '@,48-52'], ['xxx', '@48']],
+      \ 'iskeyword': [['', '@', '@,48-52'], ['xxx', '@48']],
+      \ 'isprint': [['', '@', '@,48-52'], ['xxx', '@48']],
+      \ 'keymap': [['', 'accents'], ['xxx']],
+      \ 'keymodel': [['', 'startsel', 'startsel,stopsel'], ['xxx']],
+      \ 'langmap': [['', 'xX', 'aA,bB'], ['xxx']],
+      \ 'listchars': [['', 'eol:x', 'eol:x,space:y'], ['xxx']],
+      \ 'matchpairs': [['', '(:)', '(:),<:>'], ['xxx']],
+      \ 'mkspellmem': [['10000,100,12'], ['', 'xxx']],
+      \ 'mouse': [['', 'a', 'nvi'], ['xxx', 'n,v,i']],
+      \ 'mousemodel': [['', 'popup'], ['xxx']],
+      \ 'mouseshape': [['', 'n:arrow'], ['xxx']],
+      \ 'nrformats': [['', 'alpha', 'alpha,hex,bin'], ['xxx']],
+      \ 'printmbfont': [['', 'r:some', 'b:Bold,c:yes'], ['xxx']],
+      \ 'printoptions': [['', 'header:0', 'left:10pc,top:5pc'], ['xxx']],
+      \ 'scrollopt': [['', 'ver', 'ver,hor'], ['xxx']],
+      \ 'selection': [['old', 'inclusive'], ['', 'xxx']],
+      \ 'selectmode': [['', 'mouse', 'key,cmd'], ['xxx']],
+      \ 'sessionoptions': [['', 'blank', 'help,options,slash'], ['xxx']],
+      \ 'signcolumn': [['', 'auto', 'no'], ['xxx', 'no,yes']],
+      \ 'spellfile': [['', 'file.en.add'], ['xxx', '/tmp/file']],
+      \ 'spellsuggest': [['', 'best', 'double,33'], ['xxx']],
+      \ 'switchbuf': [['', 'useopen', 'split,newtab'], ['xxx']],
+      \ 'tagcase': [['smart', 'match'], ['', 'xxx', 'smart,match']],
+      \ 'term': [['ansi'], ['', 'gui']],
+      \ 'toolbar': [['', 'icons', 'text'], ['xxx']],
+      \ 'toolbariconsize': [['', 'tiny', 'huge'], ['xxx']],
+      \ 'ttymouse': [['', 'xterm'], ['xxx']],
+      \ 'ttytype': [['ansi'], ['', 'gui']],
+      \ 'viewoptions': [['', 'cursor', 'unix,slash'], ['xxx']],
+      \ 'viminfo': [['', '''50', '"30'], ['xxx']],
+      \ 'virtualedit': [['', 'all', 'all,block'], ['xxx']],
+      \ 'whichwrap': [['', 'b,s', 'bs'], ['xxx']],
+      \ 'wildmode': [['', 'full', 'list:full', 'full,longest'], ['xxx']],
+      \ 'wildoptions': [['', 'tagfile'], ['xxx']],
+      \ 'winaltkeys': [['menu', 'no'], ['', 'xxx']],
+      \
+      \ 'luadll': [[], []],
+      \ 'perldll': [[], []],
+      \ 'pythondll': [[], []],
+      \ 'pythonthreedll': [[], []],
+      \ 'pyxversion': [[], []],
+      \ 'rubydll': [[], []],
+      \ 'tcldll': [[], []],
+      \
+      \ 'othernum': [[-1, 0, 100], ['']],
+      \ 'otherstring': [['', 'xxx'], []],
+      \}
+
+1
+/struct vimoption options
+while 1
+  /{"
+  if line('.') > end
+    break
+  endif
+  let line = getline('.')
+  let name = substitute(line, '.*{"\([^"]*\)".*', '\1', '')
+  let shortname = substitute(line, '.*"\([^"]*\)".*', '\1', '')
+
+  if has_key(test_values, name)
+    let a = test_values[name]
+  elseif line =~ 'P_NUM'
+    let a = test_values['othernum']
+  else
+    let a = test_values['otherstring']
+  endif
+  if len(a[0]) > 0 || len(a[1]) > 0
+    if line =~ 'P_BOOL'
+      call add(script, 'set ' . name)
+      call add(script, 'set ' . shortname)
+      call add(script, 'set no' . name)
+      call add(script, 'set no' . shortname)
+    else
+      for val in a[0]
+	call add(script, 'set ' . name . '=' . val)
+	call add(script, 'set ' . shortname . '=' . val)
+
+	if name == 'verbosefile' && !empty(val)
+	  call add(script, 'call delete("'. val. '")')
+	endif
+      endfor
+
+      " setting an option can only fail when it's implemented.
+      call add(script, "if exists('+" . name . "')")
+      for val in a[1]
+	call add(script, "call assert_fails('set " . name . "=" . val . "')")
+	call add(script, "call assert_fails('set " . shortname . "=" . val . "')")
+      endfor
+      call add(script, "endif")
+    endif
+
+    call add(script, 'set ' . name . '&')
+    call add(script, 'set ' . shortname . '&')
+
+    if name == 'more'
+      call add(script, 'set nomore')
+    endif
+  endif
+endwhile
+
+call add(script, 'let &term = save_term')
+call add(script, 'let &columns = save_columns')
+call add(script, 'let &lines = save_lines')
+
+call writefile(script, 'testdir/opt_test.vim')
+
+endif
+
+qa!
--- a/src/version.c
+++ b/src/version.c
@@ -765,6 +765,8 @@ static char *(features[]) =
 static int included_patches[] =
 {   /* Add new patch number below this line */
 /**/
+    428,
+/**/
     427,
 /**/
     426,