Mercurial > vim
changeset 21843:4a4678d26822 v8.2.1471
patch 8.2.1471: :const only locks the variable, not the value
Commit: https://github.com/vim/vim/commit/241572794f7e93d2f8b762de2300e5f7e4f07628
Author: Bram Moolenaar <Bram@vim.org>
Date: Sun Aug 16 22:50:01 2020 +0200
patch 8.2.1471: :const only locks the variable, not the value
Problem: :const only locks the variable, not the value.
Solution: Lock the value as ":lockvar 1 var" would do. (closes https://github.com/vim/vim/issues/6719)
| author | Bram Moolenaar <Bram@vim.org> |
|---|---|
| date | Sun, 16 Aug 2020 23:00:04 +0200 |
| parents | f40d7d8ca768 |
| children | 69aca436df65 |
| files | src/evalvars.c src/testdir/test_const.vim src/version.c |
| diffstat | 3 files changed, 11 insertions(+), 5 deletions(-) [+] |
line wrap: on
line diff
--- a/src/evalvars.c +++ b/src/evalvars.c @@ -3087,7 +3087,7 @@ set_var_const( } if (flags & LET_IS_CONST) - di->di_tv.v_lock |= VAR_LOCKED; + item_lock(&di->di_tv, 1, TRUE); } /*
--- a/src/testdir/test_const.vim +++ b/src/testdir/test_const.vim @@ -41,6 +41,7 @@ func Test_define_var_with_lock() call assert_fails('let s = "vim"', 'E741:') call assert_fails('let F = funcref("s:noop")', 'E741:') call assert_fails('let l = [1, 2, 3]', 'E741:') + call assert_fails('call filter(l, "v:val % 2 == 0")', 'E741:') call assert_fails('let d = {"foo": 10}', 'E741:') if has('channel') call assert_fails('let j = test_null_job()', 'E741:') @@ -276,13 +277,16 @@ func Test_lock_depth_is_1() const l = [1, 2, 3] const d = {'foo': 10} - " Modify list - call add(l, 4) + " Modify list - setting item is OK, adding/removing items not let l[0] = 42 + call assert_fails('call add(l, 4)', 'E741:') + call assert_fails('unlet l[1]', 'E741:') - " Modify dict - let d['bar'] = 'hello' + " Modify dict - changing item is OK, adding/removing items not + let d['foo'] = 'hello' let d.foo = 44 + call assert_fails("let d['bar'] = 'hello'", 'E741:') + call assert_fails("unlet d['foo']", 'E741:') endfunc " vim: shiftwidth=2 sts=2 expandtab