Mercurial > vim
changeset 34269:22be86ed7545 v9.1.0073
patch 9.1.0073: Looping over modifier_keys_table unnecessarily
Commit: https://github.com/vim/vim/commit/0c989e4a3ae50085aa8c6bed5d6701760191bc1d
Author: zeertzjq <zeertzjq@outlook.com>
Date: Sat Feb 3 18:04:05 2024 +0100
patch 9.1.0073: Looping over modifier_keys_table unnecessarily
Problem: Looping over modifier_keys_table[] unnecessarily with only
MOD_MASK_ALT or MOD_MASK_CMD, as modifier_keys_table[] only
contains MOD_MASK_SHIFT and MOD_MASK_CTRL, and the loop won't
do anything.
Solution: Remove MOD_MASK_ALT and MOD_MASK_CMD from the condition.
(zeertzjq)
closes: #13963
Signed-off-by: zeertzjq <zeertzjq@outlook.com>
Signed-off-by: Christian Brabandt <cb@256bit.org>
author | Christian Brabandt <cb@256bit.org> |
---|---|
date | Sat, 03 Feb 2024 18:15:02 +0100 |
parents | a011b0b275ac |
children | ecd5eec51980 |
files | src/misc2.c src/version.c |
diffstat | 2 files changed, 3 insertions(+), 5 deletions(-) [+] |
line wrap: on
line diff
--- a/src/misc2.c +++ b/src/misc2.c @@ -1130,11 +1130,7 @@ simplify_key(int key, int *modifiers) int key0; int key1; - if (!(*modifiers & (MOD_MASK_SHIFT | MOD_MASK_CTRL | MOD_MASK_ALT -#ifdef FEAT_GUI_GTK - | MOD_MASK_CMD -#endif - ))) + if (!(*modifiers & (MOD_MASK_SHIFT | MOD_MASK_CTRL))) return key; // TAB is a special case