Mercurial > vim
changeset 17334:1ac1d34bbdbf v8.1.1666
patch 8.1.1666: click in popup window scrollbar with border doesn't scroll
commit https://github.com/vim/vim/commit/bd42b31780794fa751597cf3aa4d1d01889b1494
Author: Bram Moolenaar <Bram@vim.org>
Date: Fri Jul 12 16:35:34 2019 +0200
patch 8.1.1666: click in popup window scrollbar with border doesn't scroll
Problem: Click in popup window scrollbar with border doesn't scroll.
Solution: Correct column for the border. (Naruhiko Nishino, closes https://github.com/vim/vim/issues/4650)
| author | Bram Moolenaar <Bram@vim.org> |
|---|---|
| date | Fri, 12 Jul 2019 16:45:05 +0200 |
| parents | 65c1e105c8ab |
| children | aea46b52b2dc |
| files | src/popupwin.c src/testdir/dumps/Test_popupwin_scroll_9.dump src/testdir/test_popupwin.vim src/version.c |
| diffstat | 4 files changed, 10 insertions(+), 7 deletions(-) [+] |
line wrap: on
line diff
--- a/src/popupwin.c +++ b/src/popupwin.c @@ -317,7 +317,7 @@ popup_handle_scrollbar_click(win_T *wp, return; if (row >= wp->w_popup_border[0] && row < height - wp->w_popup_border[2] - && col == popup_width(wp) - 1) + && col == popup_width(wp) - wp->w_popup_border[1] - 1) { if (row >= height / 2) {
--- a/src/testdir/dumps/Test_popupwin_scroll_9.dump +++ b/src/testdir/dumps/Test_popupwin_scroll_9.dump @@ -1,10 +1,10 @@ >1+0&#ffffff0| @73 |2| @73 -|3| @73 -|4| @31|f+0#0000001#ffd7ff255|i|v|e| @3| +0#0000000#ff404010| +0&#ffffff0@32 -|5| @31|s+0#0000001#ffd7ff255|i|x| @4| +0#0000000#ff404010| +0&#ffffff0@32 -|6| @31|s+0#0000001#ffd7ff255|e|v|e|n| @2| +0#0000000#4040ff13| +0&#ffffff0@32 -|7| @31|e+0#0000001#ffd7ff255|i|g|h|t| @2| +0#0000000#4040ff13| +0&#ffffff0@32 -|8| @73 +|3| @30|╔+0#0000001#ffd7ff255|═@8|X| +0#0000000#ffffff0@31 +|4| @30|║+0#0000001#ffd7ff255|f|i|v|e| @3| +0#0000000#ff404010|║+0#0000001#ffd7ff255| +0#0000000#ffffff0@31 +|5| @30|║+0#0000001#ffd7ff255|s|i|x| @4| +0#0000000#ff404010|║+0#0000001#ffd7ff255| +0#0000000#ffffff0@31 +|6| @30|║+0#0000001#ffd7ff255|s|e|v|e|n| @2| +0#0000000#4040ff13|║+0#0000001#ffd7ff255| +0#0000000#ffffff0@31 +|7| @30|║+0#0000001#ffd7ff255|e|i|g|h|t| @2| +0#0000000#4040ff13|║+0#0000001#ffd7ff255| +0#0000000#ffffff0@31 +|8| @30|╚+0#0000001#ffd7ff255|═@8|╝| +0#0000000#ffffff0@31 |9| @73 |:|c|a|l@1| |C|l|i|c|k|B|o|t|(|)| @40|1|,|1| @10|T|o|p|
--- a/src/testdir/test_popupwin.vim +++ b/src/testdir/test_popupwin.vim @@ -1580,6 +1580,7 @@ func Test_popup_scrollbar() call feedkeys("\<F4>\<LeftMouse>", "xt") endfunc func ClickBot() + call popup_setoptions(g:winid, {'border': [], 'close': 'button'}) call feedkeys("\<F5>\<LeftMouse>", "xt") endfunc map <silent> <F3> :call test_setmouse(5, 36)<CR>