Mercurial > vim
changeset 25224:10a5eb15a3bf v8.2.3148
patch 8.2.3148: Vim9: function arg type check does not handle base offset
Commit: https://github.com/vim/vim/commit/5231224e11bf468f5366a7400414368908c40795
Author: Bram Moolenaar <Bram@vim.org>
Date: Sun Jul 11 18:23:19 2021 +0200
patch 8.2.3148: Vim9: function arg type check does not handle base offset
Problem: Vim9: function arg type check does not handle base offset.
Solution: Take the base offset into account when checking builtin function
argument types.
| author | Bram Moolenaar <Bram@vim.org> |
|---|---|
| date | Sun, 11 Jul 2021 18:30:03 +0200 |
| parents | e9d91ed52493 |
| children | 2bdf399b2884 |
| files | src/evalfunc.c src/testdir/test_vim9_builtin.vim src/version.c src/vim9compile.c |
| diffstat | 4 files changed, 17 insertions(+), 1 deletions(-) [+] |
line wrap: on
line diff
--- a/src/evalfunc.c +++ b/src/evalfunc.c @@ -450,6 +450,7 @@ argcheck_T arg2_dict_string_or_nr[] = {a argcheck_T arg2_string_dict[] = {arg_string, arg_dict_any}; argcheck_T arg2_listblob_item[] = {arg_list_or_blob, arg_item_of_prev}; argcheck_T arg2_execute[] = {arg_string_or_list, arg_string}; +argcheck_T arg23_win_execute[] = {arg_number, arg_string_or_list, arg_string}; argcheck_T arg23_extend[] = {arg_list_or_dict, arg_same_as_prev, arg_extend3}; argcheck_T arg23_extendnew[] = {arg_list_or_dict, arg_same_struct_as_prev, arg_extend3}; argcheck_T arg3_string[] = {arg_string, arg_string, arg_string}; @@ -1832,7 +1833,7 @@ static funcentry_T global_functions[] = ret_string, f_visualmode}, {"wildmenumode", 0, 0, 0, NULL, ret_number, f_wildmenumode}, - {"win_execute", 2, 3, FEARG_2, NULL, + {"win_execute", 2, 3, FEARG_2, arg23_win_execute, ret_string, f_win_execute}, {"win_findbuf", 1, 1, FEARG_1, arg1_number, ret_list_number, f_win_findbuf},
--- a/src/testdir/test_vim9_builtin.vim +++ b/src/testdir/test_vim9_builtin.vim @@ -2305,6 +2305,8 @@ enddef def Test_win_execute() assert_equal("\n" .. winnr(), win_execute(win_getid(), 'echo winnr()')) + assert_equal("\n" .. winnr(), 'echo winnr()'->win_execute(win_getid())) + assert_equal("\n" .. winnr(), win_execute(win_getid(), 'echo winnr()', 'silent')) assert_equal('', win_execute(342343, 'echo winnr()')) enddef
--- a/src/version.c +++ b/src/version.c @@ -756,6 +756,8 @@ static char *(features[]) = static int included_patches[] = { /* Add new patch number below this line */ /**/ + 3148, +/**/ 3147, /**/ 3146,
--- a/src/vim9compile.c +++ b/src/vim9compile.c @@ -1781,6 +1781,7 @@ generate_BCALL(cctx_T *cctx, int func_id garray_T *stack = &cctx->ctx_type_stack; int argoff; type_T **argtypes = NULL; + type_T *shuffled_argtypes[MAX_FUNC_ARGS]; type_T *maptype = NULL; RETURN_OK_IF_SKIP(cctx); @@ -1800,6 +1801,16 @@ generate_BCALL(cctx_T *cctx, int func_id { // Check the types of the arguments. argtypes = ((type_T **)stack->ga_data) + stack->ga_len - argcount; + if (method_call && argoff > 1) + { + int i; + + for (i = 0; i < argcount; ++i) + shuffled_argtypes[i] = (i < argoff - 1) + ? argtypes[i + 1] + : (i == argoff - 1) ? argtypes[0] : argtypes[i]; + argtypes = shuffled_argtypes; + } if (internal_func_check_arg_types(argtypes, func_idx, argcount, cctx) == FAIL) return FAIL;