Mercurial > vim
changeset 2630:0de47f0d731e v7.3.051
updated for version 7.3.051
Problem: Crash when /home/mool/bin:/usr/local/sbin:/usr/local/bin:/home/mool/java/jdk/bin:/bin:/sbin:/usr/bin:/usr/games:/usr/sbin:/usr/X11R6/bin:/usr/local/linux-jdk1.3.1/bin:/usr/local/lib/python2.2/Tools/idle is empty.
Solution: Check for vim_getenv() returning NULL. (Yasuhiro Matsumoto)
| author | Bram Moolenaar <bram@vim.org> |
|---|---|
| date | Wed, 10 Nov 2010 15:37:05 +0100 |
| parents | 1ccc1ace9e5b |
| children | f896a7dfd47d |
| files | src/ex_getln.c src/os_win32.c src/version.c |
| diffstat | 3 files changed, 20 insertions(+), 5 deletions(-) [+] |
line wrap: on
line diff
--- a/src/ex_getln.c +++ b/src/ex_getln.c @@ -4747,7 +4747,11 @@ expand_shellcmd(filepat, num_file, file, || (pat[1] == '.' && vim_ispathsep(pat[2]))))) path = (char_u *)"."; else + { path = vim_getenv((char_u *)"PATH", &mustfree); + if (path == NULL) + path = (char_u *)""; + } /* * Go over all directories in $PATH. Expand matches in that directory and
--- a/src/os_win32.c +++ b/src/os_win32.c @@ -211,13 +211,16 @@ static char_u *exe_path = NULL; static void get_exe_name(void) { - char temp[MAXPATHL]; + /* Maximum length of $PATH is more than MAXPATHL. 8191 is often mentioned + * as the maximum length that works (plus a NUL byte). */ +#define MAX_ENV_PATH_LEN 8192 + char temp[MAX_ENV_PATH_LEN]; char_u *p; if (exe_name == NULL) { /* store the name of the executable, may be used for $VIM */ - GetModuleFileName(NULL, temp, MAXPATHL - 1); + GetModuleFileName(NULL, temp, MAX_ENV_PATH_LEN - 1); if (*temp != NUL) exe_name = FullName_save((char_u *)temp, FALSE); } @@ -232,10 +235,16 @@ get_exe_name(void) * "!xxd" it's found in our starting directory. Needed because * SearchPath() also looks there. */ p = mch_getenv("PATH"); - if (STRLEN(p) + STRLEN(exe_path) + 2 < MAXPATHL) + if (p == NULL + || STRLEN(p) + STRLEN(exe_path) + 2 < MAX_ENV_PATH_LEN) { - STRCPY(temp, p); - STRCAT(temp, ";"); + if (p == NULL || *p == NUL) + temp[0] = NUL; + else + { + STRCPY(temp, p); + STRCAT(temp, ";"); + } STRCAT(temp, exe_path); vim_setenv((char_u *)"PATH", temp); }