Mercurial > vim
changeset 17223:07bbe73b8e74 v8.1.1611
patch 8.1.1611: bufadd() reuses existing buffer without a name
commit https://github.com/vim/vim/commit/892ae723ab95e429222e930cf41b32809567e58e
Author: Bram Moolenaar <Bram@vim.org>
Date: Sun Jun 30 20:33:01 2019 +0200
patch 8.1.1611: bufadd() reuses existing buffer without a name
Problem: Bufadd() reuses existing buffer without a name.
Solution: When the name is empty always create a new buffer.
author | Bram Moolenaar <Bram@vim.org> |
---|---|
date | Sun, 30 Jun 2019 20:45:05 +0200 |
parents | 7fcb78851cde |
children | e92df9dfef0f |
files | src/evalfunc.c src/testdir/test_functions.vim src/version.c |
diffstat | 3 files changed, 19 insertions(+), 1 deletions(-) [+] |
line wrap: on
line diff
--- a/src/evalfunc.c +++ b/src/evalfunc.c @@ -1929,7 +1929,9 @@ find_buffer(typval_T *avar) static void f_bufadd(typval_T *argvars, typval_T *rettv) { - rettv->vval.v_number = buflist_add(tv_get_string(&argvars[0]), 0); + char_u *name = tv_get_string(&argvars[0]); + + rettv->vval.v_number = buflist_add(*name == NUL ? NULL : name, 0); } /*
--- a/src/testdir/test_functions.vim +++ b/src/testdir/test_functions.vim @@ -1539,6 +1539,20 @@ func Test_bufadd_bufload() call assert_equal(['some', 'text'], getbufline(buf, 1, '$')) call assert_equal(curbuf, bufnr('')) + let buf1 = bufadd('') + let buf2 = bufadd('') + call assert_notequal(0, buf1) + call assert_notequal(0, buf2) + call assert_notequal(buf1, buf2) + call assert_equal(1, bufexists(buf1)) + call assert_equal(1, bufexists(buf2)) + call assert_equal(0, bufloaded(buf1)) + exe 'bwipe ' .. buf1 + call assert_equal(0, bufexists(buf1)) + call assert_equal(1, bufexists(buf2)) + exe 'bwipe ' .. buf2 + call assert_equal(0, bufexists(buf2)) + bwipe someName bwipe otherName call assert_equal(0, bufexists('someName'))