# HG changeset patch # User Christian Brabandt # Date 1705078804 -3600 # Node ID 805808a558cf5f4fa9e9181b55de5f80af0bfe61 # Parent 8b2a428e4ec9a9783ed9396e115f9f4ac51ca7bc patch 9.1.0022: Coverity complains about improper use of negative value Commit: https://github.com/vim/vim/commit/49471963fefbdf78239d9066d84e14e1876fb177 Author: Christian Brabandt Date: Fri Jan 12 17:48:08 2024 +0100 patch 9.1.0022: Coverity complains about improper use of negative value Problem: Coverity complains about improper use of negative value Solution: Add a condition to validate that keytyped is larger or equal to 0 Apparently patch 9.1.0006 made it more explicit for Coverity, that the TOLOWER_LOC() macros do not handle negative values properly. However, that condition has always been there even before that, so add a condition to verify that keytyped is indeed at least 0 closes: #13824 Signed-off-by: Christian Brabandt diff --git a/src/cindent.c b/src/cindent.c --- a/src/cindent.c +++ b/src/cindent.c @@ -4108,7 +4108,8 @@ in_cinkeys( } else // TODO: multi-byte - if (keytyped == (int)p[-1] || (icase && keytyped < 256 + if (keytyped == (int)p[-1] || (icase + && keytyped < 256 && keytyped >= 0 && TOLOWER_LOC(keytyped) == TOLOWER_LOC((int)p[-1]))) { line = ml_get_cursor(); diff --git a/src/version.c b/src/version.c --- a/src/version.c +++ b/src/version.c @@ -705,6 +705,8 @@ static char *(features[]) = static int included_patches[] = { /* Add new patch number below this line */ /**/ + 22, +/**/ 21, /**/ 20,