# HG changeset patch # User Bram Moolenaar # Date 1662289203 -7200 # Node ID c9fe7d5e0f61239750ed1f0ae5009b5e25b3b05f # Parent c290472b786b4763f00b4e20425189ac87a4bc8d patch 9.0.0374: Coverity still complains about dropping sign of character Commit: https://github.com/vim/vim/commit/3c7707680fea0881fe96c75f962af01edf810d5d Author: Bram Moolenaar Date: Sun Sep 4 11:55:19 2022 +0100 patch 9.0.0374: Coverity still complains about dropping sign of character Problem: Coverity still complains about dropping sign of character. Solution: Add intermediate variable. diff --git a/src/spellfile.c b/src/spellfile.c --- a/src/spellfile.c +++ b/src/spellfile.c @@ -404,7 +404,7 @@ spell_load_file( *
: */ for (i = 0; i < VIMSPELLMAGICL; ++i) - buf[i] = (unsigned)getc(fd); // + buf[i] = c = getc(fd); // if (STRNCMP(buf, VIMSPELLMAGIC, VIMSPELLMAGICL) != 0) { emsg(_(e_this_does_not_look_like_spell_file)); @@ -700,7 +700,7 @@ suggest_load_files(void) * : */ for (i = 0; i < VIMSUGMAGICL; ++i) - buf[i] = (unsigned)getc(fd); // + buf[i] = c = getc(fd); // if (STRNCMP(buf, VIMSUGMAGIC, VIMSUGMAGICL) != 0) { semsg(_(e_this_does_not_look_like_sug_file_str), @@ -841,13 +841,14 @@ read_cnt_string(FILE *fd, int cnt_bytes, read_region_section(FILE *fd, slang_T *lp, int len) { int i; + int c; if (len > MAXREGIONS * 2) return SP_FORMERROR; for (i = 0; i < len; ++i) - lp->sl_regions[i] = (unsigned)getc(fd); // + lp->sl_regions[i] = c = getc(fd); // lp->sl_regions[len] = NUL; - return 0; + return c == EOF ? SP_TRUNCERROR : 0; } /* @@ -898,6 +899,7 @@ read_prefcond_section(FILE *fd, slang_T int cnt; int i; int n; + int c; char_u *p; char_u buf[MAXWLEN + 1]; @@ -925,7 +927,9 @@ read_prefcond_section(FILE *fd, slang_T buf[0] = '^'; // always match at one position only p = buf + 1; while (n-- > 0) - *p++ = (unsigned)getc(fd); // + *p++ = c = getc(fd); // + if (c == EOF) + break; *p = NUL; lp->sl_prefprog[i] = vim_regcomp(buf, RE_MAGIC + RE_STRING); } @@ -1063,7 +1067,7 @@ read_sal_section(FILE *fd, slang_T *slan // store the char we got while checking for end of sm_lead *p++ = c; for (++i; i < ccnt; ++i) - *p++ = (unsigned)getc(fd); // + *p++ = c = getc(fd); // *p++ = NUL; // diff --git a/src/version.c b/src/version.c --- a/src/version.c +++ b/src/version.c @@ -708,6 +708,8 @@ static char *(features[]) = static int included_patches[] = { /* Add new patch number below this line */ /**/ + 374, +/**/ 373, /**/ 372,