# HG changeset patch # User Bram Moolenaar # Date 1656584104 -7200 # Node ID 72d1b2ea70dc3c4e091d17c29c40a215e40d7447 # Parent 38a15f3738a2e5da5749eef692d324d2c231a971 patch 9.0.0010: returning 0 for has('patch-9.0.0') is inconsistent Commit: https://github.com/vim/vim/commit/b0375d466e5ca57dca71995c342870b3226d8115 Author: Bram Moolenaar Date: Thu Jun 30 11:03:39 2022 +0100 patch 9.0.0010: returning 0 for has('patch-9.0.0') is inconsistent Problem: Returning 0 for has('patch-9.0.0') is inconsistent. Solution: Make it return 1. (closes https://github.com/vim/vim/issues/10640) diff --git a/src/testdir/test_functions.vim b/src/testdir/test_functions.vim --- a/src/testdir/test_functions.vim +++ b/src/testdir/test_functions.vim @@ -40,6 +40,9 @@ func Test_has() " Will we ever have patch 9999? let ver = 'patch-' .. v:version / 100 .. '.' .. v:version % 100 .. '.9999' call assert_equal(0, has(ver)) + + " There actually isn't a patch 9.0.0, but this is more consistent. + call assert_equal(1, has('patch-9.0.0')) endfunc func Test_empty() diff --git a/src/version.c b/src/version.c --- a/src/version.c +++ b/src/version.c @@ -736,6 +736,8 @@ static char *(features[]) = static int included_patches[] = { /* Add new patch number below this line */ /**/ + 10, +/**/ 9, /**/ 8, @@ -789,11 +791,13 @@ has_patch(int n) // Perform a binary search. l = 0; h = (int)ARRAY_LENGTH(included_patches) - 1; - while (l < h) + for (;;) { m = (l + h) / 2; if (included_patches[m] == n) return TRUE; + if (l == h) + break; if (included_patches[m] < n) h = m; else