# HG changeset patch # User Bram Moolenaar # Date 1638619205 -3600 # Node ID 1bbb884c8561e82c3d19df852dbe5510839abe1e # Parent 42c7018feb3424dd594125efc63fa17a6c9a45f1 patch 8.2.3733: Vim9: using "legacy" before range does not work Commit: https://github.com/vim/vim/commit/b579f6ebbfa826d228abec1e1b24c05894517c27 Author: Bram Moolenaar Date: Sat Dec 4 11:57:00 2021 +0000 patch 8.2.3733: Vim9: using "legacy" before range does not work Problem: Vim9: using "legacy" before range does not work. Solution: Skip over range before parsing command. (closes https://github.com/vim/vim/issues/9270) diff --git a/src/testdir/test_vim9_cmd.vim b/src/testdir/test_vim9_cmd.vim --- a/src/testdir/test_vim9_cmd.vim +++ b/src/testdir/test_vim9_cmd.vim @@ -1019,6 +1019,11 @@ def Test_range_after_command_modifier() CheckScriptSuccess(['vim9script', 'silent keepjump :1d _']) assert_equal('', getline(1)) bwipe! + + var lines =<< trim END + legacy /pat/ + END + CheckDefExecAndScriptFailure(lines, 'E486: Pattern not found: pat') enddef def Test_silent_pattern() diff --git a/src/usercmd.c b/src/usercmd.c --- a/src/usercmd.c +++ b/src/usercmd.c @@ -1394,6 +1394,7 @@ produce_cmdmods(char_u *buf, cmdmod_T *c #ifdef HAVE_SANDBOX {CMOD_SANDBOX, "sandbox"}, #endif + {CMOD_LEGACY, "legacy"}, {0, NULL} }; diff --git a/src/version.c b/src/version.c --- a/src/version.c +++ b/src/version.c @@ -754,6 +754,8 @@ static char *(features[]) = static int included_patches[] = { /* Add new patch number below this line */ /**/ + 3733, +/**/ 3732, /**/ 3731, diff --git a/src/vim9compile.c b/src/vim9compile.c --- a/src/vim9compile.c +++ b/src/vim9compile.c @@ -9903,15 +9903,15 @@ compile_def_function( * in "$ENV->func()" the "$" is not a range */ cmd = ea.cmd; - if (!(local_cmdmod.cmod_flags & CMOD_LEGACY) - && (*cmd != '$' || starts_with_colon) + if ((*cmd != '$' || starts_with_colon) && (starts_with_colon || !(*cmd == '\'' || (cmd[0] == cmd[1] && (*cmd == '+' || *cmd == '-'))))) { ea.cmd = skip_range(ea.cmd, TRUE, NULL); if (ea.cmd > cmd) { - if (!starts_with_colon) + if (!starts_with_colon + && !(local_cmdmod.cmod_flags & CMOD_LEGACY)) { semsg(_(e_colon_required_before_range_str), cmd); goto erret; @@ -9920,11 +9920,8 @@ compile_def_function( if (ends_excmd2(line, ea.cmd)) { // A range without a command: jump to the line. - line = skipwhite(line); - while (*line == ':') - ++line; generate_EXEC(&cctx, ISN_EXECRANGE, - vim_strnsave(line, ea.cmd - line)); + vim_strnsave(cmd, ea.cmd - cmd)); line = ea.cmd; goto nextline; }