# HG changeset patch # User Bram Moolenaar # Date 1630954803 -7200 # Node ID b916d59f259f43940120a4f8ed1bfa8ce3b928d8 # Parent 2d28755ff4a5eb50b6b3a46cc41fd119c2962339 patch 8.2.3408: can delete a numbered function Commit: https://github.com/vim/vim/commit/ddfc05100a29263a682dd96bb924dfde4354a654 Author: Bram Moolenaar Date: Mon Sep 6 20:56:56 2021 +0200 patch 8.2.3408: can delete a numbered function Problem: Can delete a numbered function. (Naohiro Ono) Solution: Disallow deleting a numbered function. (closes https://github.com/vim/vim/issues/8760) diff --git a/src/testdir/test_user_func.vim b/src/testdir/test_user_func.vim --- a/src/testdir/test_user_func.vim +++ b/src/testdir/test_user_func.vim @@ -434,6 +434,11 @@ func Test_del_func() func d.fn() return 1 endfunc + + " cannot delete the dict function by number + let nr = substitute(execute('echo d'), '.*function(''\(\d\+\)'').*', '\1', '') + call assert_fails('delfunction g:' .. nr, 'E475: Invalid argument: g:') + delfunc d.fn call assert_equal({'a' : 10}, d) endfunc diff --git a/src/userfunc.c b/src/userfunc.c --- a/src/userfunc.c +++ b/src/userfunc.c @@ -4669,6 +4669,13 @@ ex_delfunction(exarg_T *eap) if (eap->nextcmd != NULL) *p = NUL; + if (isdigit(*name) && fudi.fd_dict == NULL) + { + if (!eap->skip) + semsg(_(e_invarg2), eap->arg); + vim_free(name); + return; + } if (!eap->skip) fp = find_func(name, is_global, NULL); vim_free(name); diff --git a/src/version.c b/src/version.c --- a/src/version.c +++ b/src/version.c @@ -756,6 +756,8 @@ static char *(features[]) = static int included_patches[] = { /* Add new patch number below this line */ /**/ + 3408, +/**/ 3407, /**/ 3406,